New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): require uritemplate 3.0.1 #1629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a non-blocking remark.
testing/constraints-3.10.txt
Outdated
# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev", | ||
# Then this file should have foo==1.14.0 | ||
uritemplate==3.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we normally pin the minimum version in the constraints file that targets the minimum Python version supported? It would IMO make sense to explain with a comment why this particular constraint lives in the constraints-3.10 file as well (unless this particular library is different).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Peter that a comment in the 3.10 file would be desirable, but otherwise LGTM
I've reverted the change to |
Fixes #1624 馃