Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GoogleApacheHttpTransport that uses the v2 ApacheHttpTransport implementation #1568

Merged
merged 4 commits into from Oct 27, 2020
Merged

feat: add GoogleApacheHttpTransport that uses the v2 ApacheHttpTransport implementation #1568

merged 4 commits into from Oct 27, 2020

Conversation

chingor13
Copy link
Collaborator

  • Introduces a separate GoogleApacheHttpTransport that return the v2 ApacheHttpTransport implementation.
  • Deprecates the original GoogleApacheHttpTransport in favor of this one.

@chingor13 chingor13 requested a review from a team as a code owner August 26, 2020 22:11
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2020
@chingor13 chingor13 mentioned this pull request Aug 26, 2020
Closed
@chingor13
Copy link
Collaborator Author

Actually, we may want to introduce a new artifact for this (like google-api-client-apache-v2). Otherwise, we will require all users to install google-http-client-apache-v2 and the apache http client transitively.

elharo
elharo reviewed Aug 27, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[INFO] There is 1 error reported by Checkstyle 8.23 with checkstyle.xml ruleset.
[ERROR] src/main/java/com/google/api/client/googleapis/apache/v2/GoogleApacheHttpTransport.java:[1] (javadoc) JavadocPackage: Missing package-info.java file.

...ient/src/main/java/com/google/api/client/googleapis/apache/v2/GoogleApacheHttpTransport.java
import org.apache.http.config.SocketConfig;
import org.apache.http.conn.socket.LayeredConnectionSocketFactory;
import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
import org.apache.http.impl.client.HttpClientBuilder;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we avoid depending on impl classes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Official Apache HttpClient examples that configure the clients use the impl classes: https://hc.apache.org/httpcomponents-client-4.3.x/httpclient/examples/org/apache/http/examples/client/ClientProxyAuthentication.java

...ient/src/main/java/com/google/api/client/googleapis/apache/v2/GoogleApacheHttpTransport.java Outdated Show resolved Hide resolved
@chingor13
Copy link
Collaborator Author

Actually, we may want to introduce a new artifact for this (like google-api-client-apache-v2). Otherwise, we will require all users to install google-http-client-apache-v2 and the apache http client transitively.

google-http-client already has a dependency on the Apache HttpClient library so this is not introducing a new transitive dependencies (just the google-http-client-apache-v2 artifact).

@chingor13
Copy link
Collaborator Author

cc @ckiosidis Would this work for your use-case? It adds a nearly identical class that returns the non-deprecated ApacheHttpTransport implementation in a separate package namespace.

@ckiosidis
Copy link

@chingor13 Yes, thanks for moving this forward! 👍

@chingor13 chingor13 requested a review from a team September 21, 2020 23:50
@chingor13 chingor13 requested a review from elharo October 22, 2020 22:09
@chingor13 chingor13 requested a review from elharo October 27, 2020 00:03
@chingor13 chingor13 merged commit d0dbca7 into googleapis:master Oct 27, 2020
@chingor13 chingor13 deleted the v2-apache-transport branch October 27, 2020 16:05
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 10, 2020
@release-please
chore: release 1.31.0 (#1613)
266b309 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.31.0](https://www.github.com/googleapis/google-api-java-client/compare/v1.30.11...v1.31.0) (2020-11-10)


### Features

* add GoogleApacheHttpTransport that uses the v2 ApacheHttpTransport implementation ([#1568](https://www.github.com/googleapis/google-api-java-client/issues/1568)) ([d0dbca7](https://www.github.com/googleapis/google-api-java-client/commit/d0dbca720479f1ca8627c58eda195857ea0b2423))
* add mtls support to GoogleNetHttpTransport and GoogleApacheHttpTransport ([#1619](https://www.github.com/googleapis/google-api-java-client/issues/1619)) ([1d8304c](https://www.github.com/googleapis/google-api-java-client/commit/1d8304c6311e910293b800ffdbf0bb6f19cf7fff))


### Dependencies

* update dependency com.google.appengine:appengine-api-1.0-sdk to v1.9.83 ([#1622](https://www.github.com/googleapis/google-api-java-client/issues/1622)) ([10bb904](https://www.github.com/googleapis/google-api-java-client/commit/10bb90441c90cb5ea7045a1ac5d39d669fad963d))
* update dependency com.google.oauth-client:google-oauth-client-bom to v1.31.2 ([#1623](https://www.github.com/googleapis/google-api-java-client/issues/1623)) ([5942561](https://www.github.com/googleapis/google-api-java-client/commit/594256120e4eb37b0f3ca386f69542b68b53d05b))
* update google-http-client to v1.38.0 ([#1620](https://www.github.com/googleapis/google-api-java-client/issues/1620)) ([bb63ded](https://www.github.com/googleapis/google-api-java-client/commit/bb63ded8846cd515c993c288728063f35e226ec5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chingor13 @ckiosidis @elharo