Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mtls support to GoogleNetHttpTransport and GoogleApacheHttpTransport #1619

Merged
merged 33 commits into from Nov 10, 2020
Merged

feat: add mtls support to GoogleNetHttpTransport and GoogleApacheHttpTransport #1619

merged 33 commits into from Nov 10, 2020

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Nov 1, 2020 •
edited

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2020
@arithmetic1728 arithmetic1728 marked this pull request as ready for review November 2, 2020 20:10
@arithmetic1728 arithmetic1728 requested a review from a team as a code owner November 2, 2020 20:10
elharo
elharo suggested changes Nov 2, 2020
View reviewed changes
google-api-client/pom.xml Outdated Show resolved Hide resolved
chingor13
chingor13 requested changes Nov 4, 2020
View reviewed changes
...ient/src/main/java/com/google/api/client/googleapis/apache/v2/GoogleApacheHttpTransport.java Outdated Show resolved Hide resolved
google-api-client/pom.xml Outdated Show resolved Hide resolved
...pi-client/src/main/java/com/google/api/client/googleapis/javanet/GoogleNetHttpTransport.java Outdated Show resolved Hide resolved
...pi-client/src/main/java/com/google/api/client/googleapis/javanet/GoogleNetHttpTransport.java Outdated Show resolved Hide resolved
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java Outdated Show resolved Hide resolved
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java Outdated Show resolved Hide resolved
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java Outdated Show resolved Hide resolved
@chingor13
Copy link
Collaborator

BTW, google-http-client 1.38.0 is now available and updated in master

chingor13
chingor13 requested changes Nov 4, 2020
View reviewed changes
...pi-client/src/main/java/com/google/api/client/googleapis/javanet/GoogleNetHttpTransport.java Outdated Show resolved Hide resolved
...ient/src/main/java/com/google/api/client/googleapis/apache/v2/GoogleApacheHttpTransport.java Outdated Show resolved Hide resolved
...ient/src/main/java/com/google/api/client/googleapis/apache/v2/GoogleApacheHttpTransport.java Outdated Show resolved Hide resolved
...pi-client/src/main/java/com/google/api/client/googleapis/javanet/GoogleNetHttpTransport.java Outdated Show resolved Hide resolved
.../src/test/java/com/google/api/client/googleapis/apache/v2/GoogleApacheHttpTransportTest.java Outdated Show resolved Hide resolved
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java Outdated Show resolved Hide resolved
chingor13 and others added 2 commits November 5, 2020 11:54
@chingor13
refactor: implement MtlsUtils.MtlsProvider interface with default imp…
d92d3b3 
…lementation
@arithmetic1728
Merge pull request #1 from chingor13/mtls-refactor
aa72510 
refactor: implement MtlsUtils.MtlsProvider interface with default implementation
chingor13
chingor13 requested changes Nov 10, 2020
View reviewed changes
Copy link
Collaborator

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny license header nit, otherwise LGTM.

google-api-client/src/main/java/com/google/api/client/googleapis/mtls/package-info.java Outdated Show resolved Hide resolved
@arithmetic1728 @chingor13
Update google-api-client/src/main/java/com/google/api/client/googleap…
5593a90 
…is/mtls/package-info.java

Co-authored-by: Jeff Ching <chingor@google.com>
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Nov 10, 2020
@chingor13 chingor13 merged commit 1d8304c into googleapis:master Nov 10, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 10, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 10, 2020
@release-please
chore: release 1.31.0 (#1613)
266b309 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.31.0](https://www.github.com/googleapis/google-api-java-client/compare/v1.30.11...v1.31.0) (2020-11-10)


### Features

* add GoogleApacheHttpTransport that uses the v2 ApacheHttpTransport implementation ([#1568](https://www.github.com/googleapis/google-api-java-client/issues/1568)) ([d0dbca7](https://www.github.com/googleapis/google-api-java-client/commit/d0dbca720479f1ca8627c58eda195857ea0b2423))
* add mtls support to GoogleNetHttpTransport and GoogleApacheHttpTransport ([#1619](https://www.github.com/googleapis/google-api-java-client/issues/1619)) ([1d8304c](https://www.github.com/googleapis/google-api-java-client/commit/1d8304c6311e910293b800ffdbf0bb6f19cf7fff))


### Dependencies

* update dependency com.google.appengine:appengine-api-1.0-sdk to v1.9.83 ([#1622](https://www.github.com/googleapis/google-api-java-client/issues/1622)) ([10bb904](https://www.github.com/googleapis/google-api-java-client/commit/10bb90441c90cb5ea7045a1ac5d39d669fad963d))
* update dependency com.google.oauth-client:google-oauth-client-bom to v1.31.2 ([#1623](https://www.github.com/googleapis/google-api-java-client/issues/1623)) ([5942561](https://www.github.com/googleapis/google-api-java-client/commit/594256120e4eb37b0f3ca386f69542b68b53d05b))
* update google-http-client to v1.38.0 ([#1620](https://www.github.com/googleapis/google-api-java-client/issues/1620)) ([bb63ded](https://www.github.com/googleapis/google-api-java-client/commit/bb63ded8846cd515c993c288728063f35e226ec5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@elharo elharo elharo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arithmetic1728 @chingor13 @elharo