Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gencli): don't generate grpc.WithInsecure #1503

Merged
merged 4 commits into from May 6, 2024

Conversation

egonelbre
Copy link
Contributor

grpc.WithInsecure is deprecated as per https://pkg.go.dev/google.golang.org/grpc#WithInsecure

grpc.WithInsecure is deprecated
@egonelbre egonelbre requested review from a team as code owners May 3, 2024 12:01
@noahdietz noahdietz changed the title fix(gengapic): don't generate grpc.WithInsecure fix(gencli): don't generate grpc.WithInsecure May 3, 2024
noahdietz
noahdietz previously approved these changes May 3, 2024
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is in gencli not gengapic, but I've changed the title, so automerge will use the proper commit

@noahdietz noahdietz added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 3, 2024
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 3, 2024
@quartzmo quartzmo added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 6, 2024
@gcf-merge-on-green gcf-merge-on-green bot dismissed noahdietz’s stale review May 6, 2024 18:50

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@quartzmo quartzmo merged commit 27f02ea into googleapis:main May 6, 2024
7 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 6, 2024
@egonelbre egonelbre deleted the insecure branch May 7, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants