fix(gencli): don't generate grpc.WithInsecure (#1503)

grpc.WithInsecure is deprecated
googleapis · May 6, 2024 · 27f02ea · 27f02ea
1 parent 70d7d39
commit 27f02ea
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/internal/gencli/service_file.go b/internal/gencli/service_file.go
@@ -34,6 +34,7 @@ import (
 	"github.com/spf13/viper"
 	"google.golang.org/api/option"
 	"google.golang.org/grpc"
+	"google.golang.org/grpc/credentials/insecure"
 	"golang.org/x/oauth2"
 	{{ range $key, $pkg := .Imports}}
 	{{ $pkg.Name }} "{{ $pkg.Path }}"
@@ -89,7 +90,7 @@ var {{ $serviceCmdVar }} = &cobra.Command{
 				return fmt.Errorf("Missing address to use with insecure connection")
 			}
 
-			conn, err := grpc.Dial(address, grpc.WithInsecure())
+			conn, err := grpc.Dial(address, grpc.WithTransportCredentials(insecure.NewCredentials()))
 			if err != nil {
 				return err
 			}

diff --git a/internal/gencli/testdata/service_file.want b/internal/gencli/testdata/service_file.want
@@ -10,6 +10,7 @@ import (
 	"golang.org/x/oauth2"
 	"google.golang.org/api/option"
 	"google.golang.org/grpc"
+	"google.golang.org/grpc/credentials/insecure"
 
 	proto "github.com/golang/protobuf/proto"
 )
@@ -63,7 +64,7 @@ var TodoServiceCmd = &cobra.Command{
 				return fmt.Errorf("Missing address to use with insecure connection")
 			}
 
-			conn, err := grpc.Dial(address, grpc.WithInsecure())
+			conn, err := grpc.Dial(address, grpc.WithTransportCredentials(insecure.NewCredentials()))
 			if err != nil {
 				return err
 			}

diff --git a/showcase/main_test.go b/showcase/main_test.go
@@ -24,6 +24,7 @@ import (
 	showcase "github.com/googleapis/gapic-showcase/client"
 	"google.golang.org/api/option"
 	"google.golang.org/grpc"
+	"google.golang.org/grpc/credentials/insecure"
 )
 
 func init() {
@@ -47,7 +48,7 @@ var restClientOpts = []option.ClientOption{
 func TestMain(m *testing.M) {
 	flag.Parse()
 
-	conn, err := grpc.Dial("localhost:7469", grpc.WithInsecure())
+	conn, err := grpc.Dial("localhost:7469", grpc.WithTransportCredentials(insecure.NewCredentials()))
 	if err != nil {
 		log.Fatal(err)
 	}