Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules/zstd: Add sequence decoding #1362

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

modules/zstd: Add sequence decoding #1362

wants to merge 29 commits into from

Conversation

rw1nkler
Copy link
Contributor

@rw1nkler rw1nkler commented Mar 28, 2024 •
edited

This PR is meant to provide a proc implementing sequence section decoding as described in:
https://datatracker.ietf.org/doc/html/rfc8878#section-3.1.1.3.2

NOTE: this is based on #1214, please ignore commits from that branch when reviewing.

@rw1nkler rw1nkler force-pushed the 55149-fse branch 2 times, most recently from f2a9d34 to c8465a5 Compare March 29, 2024 15:31
@proppy
Copy link
Member

proppy commented Apr 3, 2024

is it independent from #1315 or should they be reviewed together?

@rw1nkler rw1nkler force-pushed the 55149-fse branch 2 times, most recently from f30c47b to 6c3b033 Compare April 4, 2024 14:09
@rw1nkler
Copy link
Contributor Author

rw1nkler commented Apr 4, 2024

is it independent from #1315 or should they be reviewed together?

We agreed that this should be reviewed as an independent PR after merging #1315

rw1nkler and others added 23 commits May 16, 2024 15:09
@rw1nkler @lpawelcz
modules/zstd: Add buffer library
17baf76 
This commit adds a DSLX Buffer library that provides the Buffer struct,
and helper functions that can be used to operate on it. The Buffer
is meant to be a storage for data coming from the channel. It acts like
a FIFO, allowing data of any length to be put in or popped out of it.
Provided DSLX tests verify the correct behaviour of the library.

Internal-tag: [#50221]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler @lpawelcz
modules/zstd: Add Buffer use-case example
63d63e9 
This commit adds a simple test that shows, how one can use the Buffer
struct inside a Proc.

Internal-tag: [#50221]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler @lpawelcz
modules/zstd: Add library for parsing magic number
c44b5d1 
This commit adds the library with functions for parsing a magic number and
tests that verify its correctness.

Internal-tag: [#50221]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler @rdob-ant @lpawelcz
modules/zstd: Add library for parsing frame header
8a41680 
This commit adds the library with functions for parsing a frame header.
The provided tests verify the correcness of the library.

Internal-tag: [#49967]
Co-authored-by: Roman Dobrodii <rdobrodii@antmicro.com>
Co-authored-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
@lpawelcz
dependency_support/libzstd: Make zstd_errors.h public
611912e 
Required for expected_status inference in C++ tests for ZSTD decoder
components

Internal-tag: [#53465]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
@rw1nkler @lpawelcz
dependency_support: Add decodecorpus binary
434deae 
Internal-tag: [#50967]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler @lpawelcz
modules/zstd: Add data generator library
87314ea 
This commit adds a binary that calls decoding to generate data and loads
it into a vector of bytes.

Internal-tag: [#50967]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler @lpawelcz
modules/zstd: Add zstd frame header tests
81c8aab 
Internal-tag: [#50967]
Co-authored-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
@rw1nkler @lpawelcz
modules/zstd: Add common zstd definitions
098762e 
Internal-tag: [#51343]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler @lpawelcz
modules/zstd: Add raw block decoder
18f498c 
Internal-tag: [#51343]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@lpawelcz
modules/zstd: Add rle block decoder
d31ecb6 
Adds RleBlockDecoder responsible for decoding Blocks
of RLE_Block Block_Type as specified in RFC 8878, paragraph 3.1.1.2.2.
https://datatracker.ietf.org/doc/html/rfc8878#section-3.1.1.2.2

RleBlockDecoder communicates through BlockDataPacket channels.
It reuses existing RunLengthDecoder block which is interfaced through
two seprate procs:

 * RleDataPacker
 * BatchPacker

Which are responsible for converting input data into format accepted by
RLE decoder and for gathering RLE decoder output symbols into batches
which are then send out through BlockDataPacket.

Internal-tag: [#51473]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
@rw1nkler @lpawelcz
modules/zstd: Add block header parsing library
5af9376 
Internal-tag: [#51343]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@lpawelcz
modules/zstd: Add SequenceExecutorPacket to common definitions
3c63b05 
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
@rw1nkler @lpawelcz
modules/zstd: Add block data muxer library
c1b657e 
This commit adds DecoderMux Proc, which collects data from specialized
Raw, RLE, and Compressed Block decoders and re-sends them in the correct order.

Internal-tag: [#51343]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@mtdudek @rw1nkler @lpawelcz
modules/zstd: Add block demuxer library
6c53600 
This DSLX proc responsibility is to dispatch encoded blocks to a correct
decoder: RAW, RLE, COMPRESSED.

It tracks and assigns block IDs.
The ID counter is reset on the frame's last block on the last data packet.

Internal-tag: [#51736]
Co-authored-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Maciej Dudek <mdudek@antmicro.com>
@lpawelcz
modules/zstd: Add block decoder module
7bfcd31 
This adds a decoder of block data. It decodes block header and
demuxes remaining input data into one of specific block decoders
depending on the type of the parsed block. Then it muxes outputs
from those decoders into single output channel.

Internal-tag: [#51873]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
@lpawelcz
xls/moduels/common: Specify decoder output format
a083037 
Internal-tag: [#52954]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
@rw1nkler @lpawelcz
examples/ram: Export internal RAM API to other modules
8d6dd22 
This commit marks SimultaneousReadWriteBehavior enum and
num_partitions function as public to allow for creating
simpler tests that interact with RAM models.

Internal-tag: [#53241]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler @lpawelcz
modules/zstd: Add Offset type to common zstd definitions
9d691be 
Internal-tag: [#54705]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler @lpawelcz
modules/zstd: Add RamPrinter Proc
d07433f 
This commit adds RAM printer block usefull for debugging
HistoryBuffer inside SequenceExecutor.

Internal-tag: [#54705]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler @lpawelcz
modules/zstd: Add SequenceExecutor Proc
d90bc17 
Add Proc responsible for handling ZSTD Sequence Execution step,
which is described in:
https://datatracker.ietf.org/doc/html/rfc8878#name-sequence-execution

Internal-tag: [#54705]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@lpawelcz
xls/modules/zstd: Add repacketizer
46dbc63 
Internal-tag: [#52954]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
@rw1nkler
modules/zstd: Add buffer implementing desired API
b9ee3e2 
Add a buffering proc that implements the desired API of the final buffering mechanism.
A more efficient implementation will be provided later.

Internal-tag: [#55149]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
rw1nkler and others added 5 commits May 22, 2024 22:12
@rw1nkler
modules/zstd: Add common FSE definitions
0931be5 
Internal-tag: [#57353]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler
modules/zstd: Add a proc handling RAM write completion
80fa379 
Internal-tag: [#57353]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler
modules/zstd: Add FSE probability frequency decoder
a47617f 
Internal-tag: [#57353]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler
modules/zstd: Add proc for generating symbol order for FSE lookup
62c5a87 
Internal-tag: [#57353]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@RRozak @rw1nkler
modules/zstd: Add CommandConstructor proc
a18563c 
Internal-tag: [#58422]
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
@rw1nkler rw1nkler changed the title modules/zstd: Add FSE decoding modules/zstd: Add sequence decoding May 24, 2024
@rw1nkler @RRozak @m-torhan
modules/zstd: Add Ram demux
22da0d6 
Internal-tag: [#58557]
Co-authored-by: Ryszard Rozak <rrozak@antmicro.com>
Co-authored-by: Maciej Torhan <mtorhan@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rw1nkler @proppy @lpawelcz @mtdudek @RRozak