Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change failure message of StringSubject.matches and add test cases #830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

junyan59
Copy link

@junyan59 junyan59 commented Mar 1, 2021

Add an additional message to suggest using containsMatch, if matches(x) fails but containsMatch(x) would have passed. Add corresponding test cases.
issue link: #791

@google-cla
Copy link

google-cla bot commented Mar 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@junyan59
Copy link
Author

junyan59 commented Mar 1, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Mar 1, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Add an additional message to suggest using containsMatch, if matches(x) fails but containsMatch(x) would have passed. Add corresponding test cases.
@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 1, 2021
@kluever kluever added P3 not scheduled type=enhancement Make an existing feature better labels Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes P3 not scheduled type=enhancement Make an existing feature better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants