Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If matches(x) fails but containsMatch(x) would have passed, suggest containsMatch in the failure message #791

Open
cpovirk opened this issue Nov 25, 2020 · 1 comment
Open

If matches(x) fails but containsMatch(x) would have passed, suggest containsMatch in the failure message #791

cpovirk opened this issue Nov 25, 2020 · 1 comment
Labels
P3 not scheduled type=enhancement Make an existing feature better

Comments

@cpovirk
Copy link
Member

cpovirk commented Nov 25, 2020

Similar in spirit to #783.

assertThat("foo bar baz").matches("ba[rz]");
<normal failure message>
Did you mean to call containsMatch() instead of match()?
@cpovirk cpovirk added P3 not scheduled type=enhancement Make an existing feature better labels Nov 25, 2020
@junyan59 junyan59 mentioned this issue Mar 1, 2021
Open
@junyan59
Copy link

junyan59 commented Mar 1, 2021

Hi @cpovirk, I made a PR for this issue #830, could you review it? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 not scheduled type=enhancement Make an existing feature better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cpovirk @junyan59