Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: expand build matrix for major OS #490

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ci: expand build matrix for major OS #490

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5087981
ci: expand build matrix for major OS
Borda Mar 11, 2024
caadb03
reoder OS
Borda Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 12 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Expand Up @@ -2,12 +2,22 @@ name: Python Fire

on: [push]

defaults:
run:
shell: bash

jobs:
build:
runs-on: ubuntu-20.04
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: ["3.5", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
fail-fast: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fail-fast: false
fail-fast: true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend false, this way you get to see what exactly failed -- is it all versions lower than 3.10? Is it Windows?

With true, if just the 3.5/Windows job failed, and all the others were cancelled, you don't get this useful info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true is by default, just make it explicit, I normally prefer to run all but it could yield quite extensive testing

os: ["ubuntu-latest", "macos-latest", "windows-latest"]
Borda marked this conversation as resolved.
Show resolved Hide resolved
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
include:
# adding some specific/older versions to the matrix
- {os: "ubuntu-20.04", python-version: "3.5"}
- {os: "ubuntu-20.04", python-version: "3.7"}

steps:
# Checkout the repo.
Expand All @@ -22,7 +32,6 @@ jobs:

# Build Python Fire using the build.sh script.
- name: Run build script
shell: bash
run: ./.github/scripts/build.sh
env:
PYTHON_VERSION: ${{ matrix.python-version }}