ci: expand build matrix for major OS #490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
commented
Mar 11, 2024
| strategy: | ||
| matrix: | ||
| python-version: ["3.5", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12"] | ||
| fail-fast: false |
There was a problem hiding this comment.
Suggested change
| fail-fast: false | |
| fail-fast: true |
There was a problem hiding this comment.
I recommend false, this way you get to see what exactly failed -- is it all versions lower than 3.10? Is it Windows?
With true, if just the 3.5/Windows job failed, and all the others were cancelled, you don't get this useful info.
There was a problem hiding this comment.
true is by default, just make it explicit, I normally prefer to run all but it could yield quite extensive testing
hugovk
reviewed
Mar 11, 2024
|
@dbieber, mind having a look and sharing your thoughts? 🦩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest including testing on Mac and Win.
also, the addition of OS builds does not need to be so extensive and could be listed in the
includesection adding 3.8 as the oldest and 3.12 as the latest python version