Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TALOS Humanoid Robot from PAL Robotics #22

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

saikishor
Copy link

This PR adds the requested models as in the issue: #21. The models are generated inspiring from the existing models in the repository.

Please feel free to suggest any suggestions to improve the quality of this PR.

Have a great day,

Best Regards,
Sai Kishor Kothakota

@saran-t
Copy link
Member

saran-t commented Sep 20, 2023

The license is incorrect, the original repo is LGPL.

@saikishor
Copy link
Author

The license is incorrect, the original repo is LGPL.

@saran-t Tomorrow, I'll talk to my team and update the proper licensing. Sorry about the issue, recently we have decided to go with Apache 2.0 for all over open-source packages. That's the reason I tagged it. However, I will verify it tomorrow and update it on those repositories too.

Thank you for understanding.

@saran-t
Copy link
Member

saran-t commented Sep 20, 2023

Great, that works even better for us :) Thanks!

@saikishor
Copy link
Author

Hello @saran-t,

We have updated the licenses on our repo: https://github.com/pal-robotics/talos_robot/blob/kinetic-devel/LICENSE. I've attached the link for you to look over.

Thank you,

Best Regards,
Sai Kishor Kothakota

@saikishor
Copy link
Author

This branch is also updated with the respective control modes

Copy link

@amirrazmjoo amirrazmjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sequence of actuators does not align with that of the joints. Following the head-related joints, the expected order should be arm_left_1_joint through arm_left_7_joint, but presently it appears in a disorderly fashion. This discrepancy is observed in the right and left arms as well as gripper joints across all control modes, impacting the order of values for 'ctrl' in position control mode as well.

@yuvaltassa
Copy link
Collaborator

@amirrazmjoo Thanks so much for helping with the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants