Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better explain out of memory error in message queue #8658

Merged

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented May 5, 2017

Also effectively saves one unnecessary call when everything is fine.

Please expand the file the same condition (buffer_end + room_needed) >= buffer_size was in fact checked at the beginning of each indented block. Instead of failing there, another FAIL_COND_V check was performed outside of the loop.

Please bear with me and double check, I don't want to break the core but saving one if on every call can be a performance improvement 馃拑

Fixes #8483 (not really a buffer overflow, more like an out of memory error).

Also effectively saves one unnecessary call when everything is fine.
@akien-mga akien-mga merged commit 18df047 into godotengine:master May 5, 2017
@Faless Faless mentioned this pull request May 12, 2017
@Faless Faless deleted the explain_out_of_mem_msg_queue_master branch June 3, 2017 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants