Better explain out of memory error in message queue #8658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also effectively saves one unnecessary call when everything is fine.
Please expand the file the same condition
(buffer_end + room_needed) >= buffer_size
was in fact checked at the beginning of each indented block. Instead of failing there, another FAIL_COND_V check was performed outside of the loop.Please bear with me and double check, I don't want to break the core but saving one
if
on every call can be a performance improvement 馃拑Fixes #8483 (not really a buffer overflow, more like an out of memory error).