List Control::has_point as a virtual method #8023
Merged
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojidar-bg
reviewed
Mar 14, 2017
scene/gui/control.cpp
Outdated
| @@ -2514,6 +2514,8 @@ void Control::_bind_methods() { | |||
| ADD_SIGNAL(MethodInfo("size_flags_changed")); | |||
| ADD_SIGNAL(MethodInfo("minimum_size_changed")); | |||
| ADD_SIGNAL(MethodInfo("modal_closed")); | |||
|
|
|||
| BIND_VMETHOD(MethodInfo("has_point")); | |||
There was a problem hiding this comment.
I think you forgot to add the argument here (might be wrong though)
According to Issue #8018, a BIND_VMETHOD macro wasn't present in scene/gui/control.cpp, while it was declared to be a virtual method in scene/gui/control.h. classes.xml was updated to also list this method in Control.
|
I think I did this right. Had to do a bit of digging to find |
bojidar-bg
approved these changes
Mar 15, 2017
neikeq
approved these changes
Mar 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Issue #8018, a BIND_VMETHOD macro wasn't present in scene/gui/control.cpp, while it was declared to be a virtual method in scene/gui/control.h.
classes.xml was updated to also list this method in the Control class.