Fix error response status code when dataset or job already exists #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm running into this too and was just about to consider contributing and fixing it. This is my workaround: def create_dataset(self, dataset, exists_ok=False):
# The exists_ok flag doesn't seem to work with the emulator,
# so work around it.
try:
return self._client.create_dataset(dataset, retry=None)
except google.api_core.exceptions.InternalServerError as e:
errors = e.errors
dataset_basename = dataset.split('.')[-1]
if exists_ok and re.match(rf'dataset {dataset_basename} is already created', errors[0]["message"]):
return
raise eObviously, it would be better to fix it in the emulator! Let me know if I can help with anything. |
|
@goccy hi just wondering what I can do to help get this PR through? |
goccy
requested changes
Dec 13, 2023
| "fmt" | ||
| "sync" | ||
| ) | ||
|
|
||
| var ErrDuplicatedDataset = errors.New("dataset is already created") |
There was a problem hiding this comment.
Please use errDuplicate function in error.go
| @@ -691,21 +691,21 @@ type datasetsInsertRequest struct { | |||
| dataset *bigqueryv2.Dataset | |||
| } | |||
|
|
|||
| func (h *datasetsInsertHandler) Handle(ctx context.Context, r *datasetsInsertRequest) (*bigqueryv2.DatasetListDatasets, error) { | |||
| func (h *datasetsInsertHandler) Handle(ctx context.Context, r *datasetsInsertRequest) (*bigqueryv2.DatasetListDatasets, *ServerError) { | |||
There was a problem hiding this comment.
It does not seem necessary to change to *ServerError type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official BigQuery documentation's error messages state that when creating a job, dataset, or table, a response of 409 should be returned if they already exist.
Currently, I have found that only the table portion has the correct response of 409, while the other two always respond with 500. Therefore, I am submitting this PR to fix this issue.
Additionally, the documentation mentions that
The error also returns when a job's writeDisposition property is set to WRITE_EMPTY and the destination table accessed by the job already exists.I have not implemented this part, but it may be considered for future improvements.This is my first PR of this repo, so please let me know if there are any issues with my PR. Thank you.