Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status code for duplicate job and datasets #257

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix status code for duplicate job and datasets #257

wants to merge 2 commits into from

Conversation

thuibr
Copy link

@thuibr thuibr commented Dec 13, 2023

No description provided.

@thuibr
Copy link
Author

thuibr commented Dec 13, 2023

@goccy this is to replace #184. I tried to address your comments, but I don't think I can use errResponse. I'm copying what's done for duplicate tables instead.

@thuibr thuibr marked this pull request as draft December 13, 2023 23:11
@thuibr
Copy link
Author

thuibr commented Dec 13, 2023

For some reason, even after making ErrDuplicatedDataset, it's still being reported as an internalError, and this equality check is returning false:

https://github.com/goccy/bigquery-emulator/pull/257/files#diff-4dacc7a06791d88085bc744a0a2aa16559cb5b9b8fddd705177bfa2fbfe41d29R683

@ohaibbq ohaibbq mentioned this pull request Apr 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@thuibr