Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DLQ): Remove DLQ limits in all Snuba consumers #5675

Merged
merged 3 commits into from Mar 26, 2024
Merged

fix(DLQ): Remove DLQ limits in all Snuba consumers #5675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b971d7
remove dlq limits
ayirr7 Mar 20, 2024
ee1037b
remove dlq limits in python consumer builder
ayirr7 Mar 20, 2024
2944ccc
Merge remote-tracking branch 'origin' into remove-dlq-limits-for-all
ayirr7 Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions rust_snuba/src/consumer.rs
View file
Open in desktop
Expand Up @@ -166,8 +166,8 @@ pub fn consumer_impl(
handle,
kafka_dlq_producer,
DlqLimit {
max_invalid_ratio: Some(0.01),
max_consecutive_count: Some(1000),
max_invalid_ratio: None,
max_consecutive_count: None,
},
None,
)
Expand Down
4 changes: 2 additions & 2 deletions snuba/consumers/consumer_builder.py
View file
Open in desktop
Expand Up @@ -396,8 +396,8 @@ def __build_default_dlq_policy(self) -> Optional[DlqPolicy[KafkaPayload]]:
Topic(self.__consumer_config.dlq_topic.physical_topic_name),
),
DlqLimit(
max_invalid_ratio=0.01,
max_consecutive_count=1000,
max_invalid_ratio=None,
max_consecutive_count=None,
),
None,
)
Expand Down