Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DLQ): Remove DLQ limits in all Snuba consumers #5675

Merged
merged 3 commits into from Mar 26, 2024

Conversation

ayirr7
Copy link
Member

@ayirr7 ayirr7 commented Mar 20, 2024

DLQ limit calculations can be unclear and can cause the consumer to crash. We can remove the limits to avoid this case.

@ayirr7 ayirr7 changed the title remove dlq limits in all Snuba consumers fix(DLQ): Remove dlq limits in all Snuba consumers Mar 20, 2024
@ayirr7 ayirr7 changed the title fix(DLQ): Remove dlq limits in all Snuba consumers fix(DLQ): Remove DLQ limits in all Snuba consumers Mar 20, 2024
@ayirr7 ayirr7 marked this pull request as ready for review March 20, 2024 21:19
@ayirr7 ayirr7 requested review from a team as code owners March 20, 2024 21:19
@lynnagara
Copy link
Member

lynnagara commented Mar 20, 2024

Can you update this in the python consuemr too?

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (7ebaf2a) to head (2944ccc).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5675   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files         900      900           
  Lines       43747    43747           
  Branches      301      301           
=======================================
  Hits        39310    39310           
  Misses       4395     4395           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ayirr7
Copy link
Member Author

ayirr7 commented Mar 25, 2024

Tested locally by running snuba devserver and sample DLQ-ing some messages.

@ayirr7 ayirr7 merged commit 4e4b896 into master Mar 26, 2024
32 checks passed
@ayirr7 ayirr7 deleted the remove-dlq-limits-for-all branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants