Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): DLQ all non-retriable messages even if schema is valid #67200

Merged
merged 1 commit into from Mar 19, 2024
Merged

feat(ingest): DLQ all non-retriable messages even if schema is valid #67200

merged 1 commit into from Mar 19, 2024

Commits on Mar 18, 2024

  1. feat(ingest): DLQ all messages even if schema is valid 

    Since ingest messages contain json bytes inside a msgpack payload
the schema cannot be relied on to determine whether to DLQ, as the
inner message can be invalid even if schema checking still passes.
This now DLQs any exception that is not marked Retriable.
    @lynnagara
    lynnagara committed Mar 18, 2024
    Copy the full SHA
    0273525 View commit details
    Browse the repository at this point in the history