feat(ingest): DLQ all non-retriable messages even if schema is valid #67200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ingest messages contain json bytes inside a msgpack payload the schema cannot be relied on to determine whether to DLQ, as the inner message can be invalid even if schema checking still passes. This now DLQs any exception that is not marked Retriable.
github-actions
bot
added
the
Scope: Backend
lynnagara
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #67200 +/- ##
==========================================
- Coverage 84.32% 84.32% -0.01%
==========================================
Files 5306 5306
Lines 237129 237128 -1
Branches 41008 41008
==========================================
- Hits 199957 199956 -1
Misses 36954 36954
Partials 218 218
|
Swatinem
approved these changes
Mar 19, 2024
jjbayer
reviewed
Mar 19, 2024
| try: | ||
| cached_value = cache.get(deduplication_key) | ||
| except Exception as exc: | ||
| raise Retriable(exc) |
There was a problem hiding this comment.
There's additional calls to redis and celery below (event_processing_store.store(data), task.delay in submit_symbolicate). Should these also be marked as Retriable?
There was a problem hiding this comment.
They should already be wrapped in Retriable -- did this in an earlier PR. Just spotted this one I forgot earlier.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ingest messages contain json bytes inside a msgpack payload the schema cannot be relied on to determine whether to DLQ, as the inner message can be invalid even if schema checking still passes. This now DLQs any exception that is not marked Retriable.