Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add topics for ingest-transactions-dlq and ingest-attachments-dlq #67072

Merged
merged 5 commits into from Mar 18, 2024
Merged

feat: Add topics for ingest-transactions-dlq and ingest-attachments-dlq #67072

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c59a4ef
feat: Add DLQ topics for ingest-transactions-dlq and ingest-attachmen…
lynnagara Mar 15, 2024
012d6cc
.
lynnagara Mar 15, 2024
59ed84f
bump lib
lynnagara Mar 18, 2024
5a99626
Merge remote-tracking branch 'origin/master' into add-topics
lynnagara Mar 18, 2024
4e9cc65
:snowflake: re-freeze requirements
getsantry[bot] Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sentry/conf/server.py
View file
Open in desktop
Expand Up @@ -3475,7 +3475,9 @@ def build_cdc_postgres_init_db_volume(settings: Any) -> dict[str, dict[str, str]
"ingest-events": "default",
"ingest-feedback-events": "default",
"ingest-attachments": "default",
"ingest-attachments-dlq": "default",
"ingest-transactions": "default",
"ingest-transactions-dlq": "default",
"ingest-metrics": "default",
"ingest-metrics-dlq": "default",
"snuba-metrics": "default",
Expand Down
2 changes: 2 additions & 0 deletions src/sentry/conf/types/kafka_definition.py
View file
Open in desktop
Expand Up @@ -28,7 +28,9 @@ class Topic(Enum):
INGEST_EVENTS_DLQ = "ingest-events-dlq"
INGEST_FEEDBACK_EVENTS = "ingest-feedback-events"
INGEST_ATTACHMENTS = "ingest-attachments"
INGEST_ATTACHMENTS_DLQ = "ingest-attachments-dlq"
INGEST_TRANSACTIONS = "ingest-transactions"
INGEST_TRANSACTIONS_DLQ = "ingest-transactions-dlq"
INGEST_METRICS = "ingest-metrics"
INGEST_METRICS_DLQ = "ingest-metrics-dlq"
SNUBA_METRICS = "snuba-metrics"
Expand Down
4 changes: 0 additions & 4 deletions tests/sentry/conf/test_kafka_definition.py
View file
Open in desktop
Expand Up @@ -16,13 +16,9 @@
# TODO: Remove this once these topics are actually registered in sentry-kafka-schemas
currently_unregistered_topics = [
"outcomes-billing",
"ingest-events",
"ingest-events-dlq",
"ingest-attachments",
"ingest-transactions",
"ingest-metrics-dlq",
"profiles",
"ingest-generic-metrics-dlq",
"ingest-occurrences",
"ingest-monitors",
]
Expand Down