Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add topics for ingest-transactions-dlq and ingest-attachments-dlq #67072

Merged
merged 5 commits into from Mar 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements-base.txt
Expand Up @@ -62,7 +62,7 @@ rfc3339-validator>=0.1.2
rfc3986-validator>=0.1.1
# [end] jsonschema format validators
sentry-arroyo>=2.16.2
sentry-kafka-schemas>=0.1.63
sentry-kafka-schemas>=0.1.64
sentry-ophio==0.2.3
sentry-redis-tools>=0.1.7
sentry-relay>=0.8.50
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev-frozen.txt
Expand Up @@ -177,7 +177,7 @@ sentry-cli==2.16.0
sentry-devenv==1.2.3
sentry-forked-django-stubs==4.2.7.post3
sentry-forked-djangorestframework-stubs==3.14.5.post1
sentry-kafka-schemas==0.1.63
sentry-kafka-schemas==0.1.64
sentry-ophio==0.2.3
sentry-redis-tools==0.1.7
sentry-relay==0.8.50
Expand Down
2 changes: 1 addition & 1 deletion requirements-frozen.txt
Expand Up @@ -119,7 +119,7 @@ rpds-py==0.15.2
rsa==4.8
s3transfer==0.10.0
sentry-arroyo==2.16.2
sentry-kafka-schemas==0.1.63
sentry-kafka-schemas==0.1.64
sentry-ophio==0.2.3
sentry-redis-tools==0.1.7
sentry-relay==0.8.50
Expand Down
2 changes: 2 additions & 0 deletions src/sentry/conf/server.py
Expand Up @@ -3475,7 +3475,9 @@ def build_cdc_postgres_init_db_volume(settings: Any) -> dict[str, dict[str, str]
"ingest-feedback-events": "default",
"ingest-feedback-events-dlq": "default",
"ingest-attachments": "default",
"ingest-attachments-dlq": "default",
"ingest-transactions": "default",
"ingest-transactions-dlq": "default",
"ingest-metrics": "default",
"ingest-metrics-dlq": "default",
"snuba-metrics": "default",
Expand Down
2 changes: 2 additions & 0 deletions src/sentry/conf/types/kafka_definition.py
Expand Up @@ -29,7 +29,9 @@ class Topic(Enum):
INGEST_FEEDBACK_EVENTS = "ingest-feedback-events"
INGEST_FEEDBACK_EVENTS_DLQ = "ingest-feedback-events-dlq"
INGEST_ATTACHMENTS = "ingest-attachments"
INGEST_ATTACHMENTS_DLQ = "ingest-attachments-dlq"
INGEST_TRANSACTIONS = "ingest-transactions"
INGEST_TRANSACTIONS_DLQ = "ingest-transactions-dlq"
INGEST_METRICS = "ingest-metrics"
INGEST_METRICS_DLQ = "ingest-metrics-dlq"
SNUBA_METRICS = "snuba-metrics"
Expand Down
2 changes: 0 additions & 2 deletions tests/sentry/conf/test_kafka_definition.py
Expand Up @@ -18,9 +18,7 @@ def test_topic_definition() -> None:
"outcomes-billing",
"ingest-attachments",
"ingest-transactions",
"ingest-metrics-dlq",
"profiles",
"ingest-generic-metrics-dlq",
"ingest-occurrences",
"ingest-monitors",
]
Expand Down