Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Unrevert #66287 #66383

Merged
merged 4 commits into from Mar 7, 2024
Merged

ref: Unrevert #66287 #66383

merged 4 commits into from Mar 7, 2024

Conversation

lynnagara
Copy link
Member

@lynnagara lynnagara commented Mar 5, 2024

This brings back #66287. It was reverted before as it depended on an earlier commit which was also reverted. Nothing has changed though.

Depends on #66381

@lynnagara lynnagara requested review from a team as code owners March 5, 2024 23:56
@lynnagara lynnagara changed the title ref: Unrevert https://github.com/getsentry/sentry/pull/66287 ref: Unrevert #66287 Mar 5, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 5, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (6fa756e) to head (740cf7f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #66383   +/-   ##
=======================================
  Coverage   84.29%   84.30%           
=======================================
  Files        5309     5309           
  Lines      237221   237224    +3     
  Branches    41038    41039    +1     
=======================================
+ Hits       199975   199980    +5     
+ Misses      37027    37025    -2     
  Partials      219      219           
Files Coverage Δ
src/sentry/consumers/__init__.py 71.22% <ø> (ø)
src/sentry/snuba/query_subscriptions/constants.py 100.00% <100.00%> (ø)
src/sentry/snuba/query_subscriptions/run.py 95.65% <100.00%> (+0.19%) ⬆️

... and 8 files with indirect coverage changes

Copy link
Member

@bmckerry bmckerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving since nothing seems immediately wrong to me, but someone more familiar with the subscriptions query consumers should likely review as well

@lynnagara lynnagara merged commit 86291d0 into master Mar 7, 2024
53 checks passed
@lynnagara lynnagara deleted the unrevert-66287 branch March 7, 2024 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants