New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Move the rest of the consumer definitions to the new style #66343
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/sentry/consumers/init.py
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66343 +/- ##
=======================================
Coverage 84.29% 84.29%
=======================================
Files 5309 5309
Lines 237222 237216 -6
Branches 41038 41036 -2
=======================================
- Hits 199972 199971 -1
+ Misses 37031 37026 -5
Partials 219 219
|
@@ -186,14 +186,7 @@ def ingest_events_options() -> list[click.Option]: | |||
), | |||
] | |||
|
|||
|
|||
_INGEST_SPANS_OPTIONS = multiprocessing_options(default_max_batch_size=100) + [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to clarify, did u remove this because it's not being used anywhere, unrelated to the control plane work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's dead code so i thought i'd clean it up
No description provided.