Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Move the rest of the consumer definitions to the new style #66343

Merged
merged 6 commits into from Mar 6, 2024

Conversation

lynnagara
Copy link
Member

No description provided.

@lynnagara lynnagara requested a review from a team as a code owner March 5, 2024 19:28
Copy link

sentry-io bot commented Mar 5, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/consumers/init.py

Function Unhandled Issue
get_stream_processor UnboundLocalError: cannot access local variable 'settings' where it is not associated with a value ...
Event Count: 48

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.29%. Comparing base (2fcdcff) to head (ebf8bd4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #66343   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files        5309     5309           
  Lines      237222   237216    -6     
  Branches    41038    41036    -2     
=======================================
- Hits       199972   199971    -1     
+ Misses      37031    37026    -5     
  Partials      219      219           
Files Coverage Δ
src/sentry/conf/types/kafka_definition.py 100.00% <100.00%> (ø)
src/sentry/consumers/__init__.py 72.93% <100.00%> (+1.70%) ⬆️

... and 3 files with indirect coverage changes

@@ -186,14 +186,7 @@ def ingest_events_options() -> list[click.Option]:
),
]


_INGEST_SPANS_OPTIONS = multiprocessing_options(default_max_batch_size=100) + [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to clarify, did u remove this because it's not being used anywhere, unrelated to the control plane work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's dead code so i thought i'd clean it up

@lynnagara lynnagara merged commit cb2ed30 into master Mar 6, 2024
49 checks passed
@lynnagara lynnagara deleted the consumer-definition-topics branch March 6, 2024 20:39
lynnagara added a commit that referenced this pull request Mar 6, 2024
…ved (#66288)

Depends on #66283 and
#66343

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants