Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ReactNativeClientOptions): Remove "tunnel" option #3771

Closed
wants to merge 5 commits into from
Closed

feat(ReactNativeClientOptions): Remove "tunnel" option #3771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
325b714
feat(ReactNativeClientOptions): Remove "tunnel" option
AliReza99 Apr 21, 2024
abaee0e
Merge branch 'main' into AliReza99/main
krystofwoldrich Apr 29, 2024
e3e0827
fix build
krystofwoldrich Apr 29, 2024
73245b5
add changelog
krystofwoldrich Apr 29, 2024
752f749
fix link
krystofwoldrich Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
@@ -1,5 +1,11 @@
# Changelog

Check failure on line 1 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / danger / danger 

Please consider adding a changelog entry for the next release.

Check notice on line 1 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / danger / danger 

### Instructions and example for changelog

Please add an entry to `CHANGELOG.md` to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

```markdown
## Unreleased

- Remove "tunnel" option ([#3771](https://github.com/getsentry/sentry-react-native/pull/3771))
```

If none of the above apply, you can opt out of this check by adding `#skip-changelog` to the PR description.

## Unreleased

### Fixes

- Remove `tunnel` from SDK Options ([#3787](https://github.com/getsentry/sentry-react-native/pull/3787))

## 5.22.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion src/js/client.ts
View file
Open in desktop
Expand Up @@ -101,7 +101,7 @@ export class ReactNativeClient extends BaseClient<ReactNativeClientOptions> {
const envelope = createUserFeedbackEnvelope(feedback, {
metadata: this._options._metadata,
dsn: this.getDsn(),
tunnel: this._options.tunnel,
tunnel: undefined,
});
this._sendEnvelope(envelope);
}
Expand Down
4 changes: 2 additions & 2 deletions src/js/options.ts
View file
Open in desktop
Expand Up @@ -201,9 +201,9 @@ export interface ReactNativeTransportOptions extends BrowserTransportOptions {
* @see ReactNativeFrontend for more information.
*/

export interface ReactNativeOptions extends Options<ReactNativeTransportOptions>, BaseReactNativeOptions {}
export interface ReactNativeOptions extends Options<ReactNativeTransportOptions>, BaseReactNativeOptions { }

export interface ReactNativeClientOptions extends ClientOptions<ReactNativeTransportOptions>, BaseReactNativeOptions {}
export interface ReactNativeClientOptions extends Omit<ClientOptions<ReactNativeTransportOptions>, 'tunnel'>, BaseReactNativeOptions { }

export interface ReactNativeWrapperOptions {
/** Props for the root React profiler */
Expand Down