feat(ReactNativeClientOptions): Remove "tunnel" option #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the "tunnel" option from the ReactNativeClientOptions type due to lack of support in React Native.
AliReza99
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
|
Hi @AliReza99, |
|
Thanks for your response, @krystofwoldrich . I appreciate your understanding of the confusion caused by the unsupported "tunnel" option. Removing the "tunnel" type is crucial because its presence leads developers to debug their apps unnecessarily, given the lack of documentation indicating its unsupported status. This change helps to streamline the development process by preventing wasted time and effort. |
|
I pulled your changes and fixed the build and added changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the "tunnel" option from the ReactNativeClientOptions type due to lack of support in React Native.
This pull request removes the "tunnel" option from the ReactNativeClientOptions type. While passing this option currently does not create issues, its presence can cause confusion, leading developers to believe that the feature works when it does not. Removing it ensures clarity and avoids potential misunderstandings in React Native projects.