Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix kafka topic default #3350

Merged
merged 3 commits into from Mar 28, 2024
Merged

fix: Fix kafka topic default #3350

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f70b37f
fix: Fix kafka topic default
lynnagara Mar 27, 2024
9449375
changelog
jjbayer Mar 28, 2024
9e2db06
Merge branch 'master' into fix-topic-default
lynnagara Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion relay-kafka/src/config.rs
View file
Open in desktop
Expand Up @@ -102,7 +102,7 @@ pub struct TopicAssignments {
#[serde(alias = "metrics", alias = "ingest-metrics")]
pub metrics_sessions: TopicAssignment,
/// Topic name for all other kinds of metrics. Defaults to the assignment of `metrics`.
#[serde(alias = "metrics_transactions", alias = "ingest-generic-metrics")]
#[serde(alias = "metrics_transactions", alias = "ingest-performance-metrics")]
Copy link
Member

@Dav1dde Dav1dde Mar 28, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure it's not both, e.g. single tenant?

In the incident channel you said it worked on single tenant, if I search for ingest-generic-metrics I do find some results in the ops repo.

Copy link
Member Author

@lynnagara lynnagara Mar 28, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the key here is the logical or default topic, what can get overridden to in each environment (such as different single tenants) via the TopicAssignment value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to find a way to validate these against what we have registered in https://github.com/getsentry/sentry-kafka-schemas/blob/main/topics/ingest-performance-metrics.yaml to avoid this happening in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're already pulling in sentry-kafka-schemas, can probably use it to validate the topics in a test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I need to spend some time to figure how to make this work + also try to remove the duplication of default topics in the file -- will follow up with something shortly.

pub metrics_generic: TopicAssignment,
/// Stacktrace topic name
pub profiles: TopicAssignment,
Expand Down