fix: Fix kafka topic default #3350
Conversation
should be ingest-performance-metrics not ingest-generic metrics INC-696
| @@ -102,7 +102,7 @@ pub struct TopicAssignments { | |||
| #[serde(alias = "metrics", alias = "ingest-metrics")] | |||
| pub metrics_sessions: TopicAssignment, | |||
| /// Topic name for all other kinds of metrics. Defaults to the assignment of `metrics`. | |||
| #[serde(alias = "metrics_transactions", alias = "ingest-generic-metrics")] | |||
| #[serde(alias = "metrics_transactions", alias = "ingest-performance-metrics")] | |||
There was a problem hiding this comment.
Are we sure it's not both, e.g. single tenant?
In the incident channel you said it worked on single tenant, if I search for ingest-generic-metrics I do find some results in the ops repo.
There was a problem hiding this comment.
Yeah, the key here is the logical or default topic, what can get overridden to in each environment (such as different single tenants) via the TopicAssignment value.
There was a problem hiding this comment.
I need to find a way to validate these against what we have registered in https://github.com/getsentry/sentry-kafka-schemas/blob/main/topics/ingest-performance-metrics.yaml to avoid this happening in the future.
There was a problem hiding this comment.
We're already pulling in sentry-kafka-schemas, can probably use it to validate the topics in a test?
There was a problem hiding this comment.
Sounds good, I need to spend some time to figure how to make this work + also try to remove the duplication of default topics in the file -- will follow up with something shortly.
* master: feat(metric-stats): Report cardinality to metric stats (#3360) release: 0.8.56 fix(perfscore): Adds span op tag to perf score totals (#3326) ref(profiles): Return retention_days as part of the Kafka message (#3362) ref(filter): Add GTmetrix to the list of web crawlers (#3363) fix: Fix kafka topic default (#3350) ref(normalization): Remove duplicated normalization (#3355) feat(feedback): Emit outcomes for user feedback events (#3026) feat(cardinality): Implement cardinality reporting (#3342)
should be ingest-performance-metrics not ingest-generic metrics
INC-696