Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper #504

Closed
wants to merge 23 commits into from
Closed

Paper #504

wants to merge 23 commits into from

Commits on Jun 27, 2023

  1. added JOSS paper draft

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    595adb0 View commit details
    Browse the repository at this point in the history
  2. Add ORCIDs

    jdannberg authored and bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    2f58df0 View commit details
    Browse the repository at this point in the history
  3. Update paper.md

    Some more things I noticed:
    
    Figure 2: I noticed that these properties are not the one mentioned in the text as being important. Would it make sense to add a sentence in the figure caption what the excess Gibbs energy and the endmember activities are useful for?
    
    Figure 3: Would it be worth mentioning the source of this data? I also don’t see the orange data points. 
    
    Figure 4: I am sure the there’s detailed documentation on the planet builder somewhere, would it make sense to link to that here? From the caption alone, it does not really become clear what the planet builder does exactly.
    jdannberg authored and bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    4e126d8 View commit details
    Browse the repository at this point in the history
  4. addressed comments

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    5460a65 View commit details
    Browse the repository at this point in the history
  5. add award number for CIG-III

    jdannberg authored and bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    082332d View commit details
    Browse the repository at this point in the history
  6. address comments from Sanne

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    4970b77 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9f34fe1 View commit details
    Browse the repository at this point in the history
  8. correct ref capitalisation

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    b2fa084 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2c4136f View commit details
    Browse the repository at this point in the history
  10. affiliation and minor edits

    tjhei authored and bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    b282c45 View commit details
    Browse the repository at this point in the history
  11. minor rewording

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    14c5414 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    829c1ab View commit details
    Browse the repository at this point in the history
  13. format chemical formulae

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    20a0e7c View commit details
    Browse the repository at this point in the history
  14. correct figure typo

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    a6e97aa View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    1b05d04 View commit details
    Browse the repository at this point in the history
  16. add references to tutorials

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    f982ed1 View commit details
    Browse the repository at this point in the history
  17. improved equilibrium text

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    67857e1 View commit details
    Browse the repository at this point in the history
  18. improved text

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    08e3843 View commit details
    Browse the repository at this point in the history
  19. improve formatting

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    f59cbbb View commit details
    Browse the repository at this point in the history
  20. address editorial comments

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    a6086a1 View commit details
    Browse the repository at this point in the history
  21. fix typos

    bobmyhill committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e3f62ab View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. Configuration menu
    Copy the full SHA
    0d8d00b View commit details
    Browse the repository at this point in the history
  2. fix typos

    bobmyhill committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    14f6f25 View commit details
    Browse the repository at this point in the history