Paper #504
Open
Paper #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobmyhill
requested review from
tjhei,
ian-r-rose,
sannecottaar,
gassmoeller and
CaymanUnterborn
gassmoeller
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Hi Bob, thanks so much for pushing this forward. I think a JOSS paper is a great way to create a new reference citation for BurnMan. I left a few comments, apart from one they are only typos. I also added @jdannberg and my financial support statement.
Let me know if you want me to make a PR or want to fix my comments yourself. Either way, you have my ok to move forward with the submission.
Thanks again!
PS: We should chat at some point about the jupyter notebooks on the new CIG site. we have a preliminary version online for testing here: https://geodynamics.org/resources/burnmannotebook.
jdannberg
approved these changes
Sep 15, 2022
sannecottaar
approved these changes
Sep 15, 2022
ian-r-rose
approved these changes
Sep 21, 2022
tjhei
approved these changes
Sep 26, 2022
bobmyhill
force-pushed
the
paper
branch
8 times, most recently
from
1dfe65d
to
c4aa883
Compare
Some more things I noticed: Figure 2: I noticed that these properties are not the one mentioned in the text as being important. Would it make sense to add a sentence in the figure caption what the excess Gibbs energy and the endmember activities are useful for? Figure 3: Would it be worth mentioning the source of this data? I also don’t see the orange data points. Figure 4: I am sure the there’s detailed documentation on the planet builder somewhere, would it make sense to link to that here? From the caption alone, it does not really become clear what the planet builder does exactly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened for approval from all authors.
Once everyone has approved, I'll submit to JOSS.