fix(gatsby): Ensure publicPath is always relative for gatsby develop #11227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
reviewed
Jan 23, 2019
| `${program.ssl ? `https` : `http`}://${ | ||
| program.host | ||
| }:${webpackPort}/`, | ||
| publicPath: process.env.GATSBY_WEBPACK_PUBLICPATH || `/`, |
There was a problem hiding this comment.
Wouldn't we still want to handle the ssl stuff? Seems like this would be a breaking change for that behavior.
If nothing else--would you be able to validate this hasn't broken that behavior?
There was a problem hiding this comment.
Just tested, works fine!
Keep in mind that the automatic certificates issued with the --https flag are explicitly issued to localhost and will only be accepted there. Using it together with the --host option will likely result in browser warnings.
This behaviour documented in https://www.gatsbyjs.org/docs/local-https/ remains the same
DSchau
approved these changes
Jan 23, 2019
This was referenced Sep 18, 2021
parhuzamos
added a commit
to parhuzamos/video-streaming-developer-docs
that referenced
this pull request
Jul 8, 2022
See related discussion: gatsbyjs/gatsby#5801 gatsbyjs/gatsby#11227 Signed-off-by: Bence <parhuzamos@parhuzamos.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
gatsby developwe were settingpublicPathforwebpack-dev-serverto an absolute url constructed from the program host, port and protocolThis is unnecessary and causes HMR and static links to break when viewed on a separate device over a network like in this screenshot below
This pull request fixes this by making the publicPath always relative
Fixes #11219 and #5801