Add fusionrc option to override main entry point #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pheew
force-pushed
the
feat/main-override
branch
from
afa7241
to
1dfa4db
Compare
pheew
force-pushed
the
feat/main-override
branch
from
1dfa4db
to
999ece8
Compare
ganemone
reviewed
Apr 22, 2020
| @@ -132,9 +132,14 @@ function getWebpackConfig(opts /*: WebpackConfigOpts */) { | |||
| legacyPkgConfig = {}, | |||
| worker, | |||
| } = opts; | |||
| const main = 'src/main.js'; | |||
| const main = fusionConfig.main || 'src/main.js'; | |||
There was a problem hiding this comment.
Could we instead just check for the existence of src/main.js or src/main.ts and update our webpack accordingly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow implementers to use a custom entry point. This opens up the ability to use FusionJS with Typescript or any other language that has babel support. I wanted to get some early feedback before I
^^ Am I forgetting anything else?
Fixes: #718