Add in fusionConfig: jsExtPattern, resolveExtensions (enable typescript) #411

Monar · 2019-05-22T14:32:55Z

This is change proposed in here: fusionjs/fusion-cli#705

We are using typescript with fusionjs for last 3 month and its working smoothly, this is minimal (generic) change that allows to embrace typescript for the app code.

CLAassistant · 2019-05-22T14:33:11Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Monar
❌ AlexMSmithCA
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

lhorie · 2019-07-09T16:04:17Z

fusion-cli/docs/fusionrc.md

+
+ ```js
+module.exports = {
+  jsExtPattern: \[jt]sx?$\,


Should this be forward slashes?

ajbogh · 2019-07-09T17:07:10Z

fusion-cli/docs/fusionrc.md

+
+ ## `resolveExtensions`
+
+ By default this is webpack default witch is: `['.wasm', '.mjs', '.js', '.json']`


Spelling: witch

Grammar nitpick:

By default this is the Webpack default which is:

derekju · 2019-07-09T17:57:27Z

fusion-cli/docs/fusionrc.md

+
+ By default this is `/\.jsx?$/`
+
+ For example, this enables to handle typescript files with addition to Babel plugins/preset:


Grammar nitpick:

For example, this enables Typescript support by adding the appropriate Babel preset:

futurist · 2019-07-21T07:18:38Z

any update for this PR? really need typescript support

Monar · 2019-07-22T07:58:41Z

I'll try to update this PR this week. Regarding those changes they do not cover running tests of typescript files. We have it working out of our own fork. I could update this PR with those changes or should I propose separate PR ?

AlexMSmithCA

Bump FYI @Monar

Monar · 2019-11-13T14:12:04Z

I was a little bit overload recently, but here I am back to work with this PR.

This change also incorporates minimal changes that allows us to have tests up and running for typescript code base.

lee-alexander · 2019-11-18T03:15:52Z

fusion-cli/build/jest/base-jest-config.js

  : process.env.TEST_REGEX ||
-    (process.env.TEST_MATCH || '**/__tests__/**/*.js').split(',');
+    (process.env.TEST_MATCH || `**/__tests__/**/*${testFileExt}`).split(',');


I'm not sure using testFileExt will work within a glob here since jsExtPattern is regex

Yep you are right, I'll address this, there will be case where source out of regexp wont work. Good catch thx, I've overlooked this.

This change is enabling test configuration for typescript projects.

AlexMSmithCA · 2019-12-26T04:42:13Z

!import

Edit: Opening a mirrored internal PR.

fusionjs-sync-bot · 2019-12-26T04:42:26Z

This pull request has been imported. If you have access to the parent repo, you can view the imported change here.

AlexMSmithCA · 2019-12-26T22:39:17Z

A canary release (0.0.0-canary.39fc7dc.0) has been cut with these changes. I haven't played around with it yet though, but it should avoid having to fork + re-release this for now.

amarinov · 2020-01-10T07:37:27Z

Thank you @Monar for the contribution and thanks to @AlexMSmithCA for cutting the canary release. My team has been using it for our migration from Flow to Typescript and that has been very useful.

One small thing to note - jsExtPattern should start with a dot jsExtPattern: /\.[jt]sx?$/ as that is being appended in testPathIgnorePatterns.

ajbogh · 2020-01-16T20:47:24Z

fusion-cli/docs/fusionrc.md

+
+ ```js
+module.exports = {
+  jsExtPattern: /[jt]sx?$/,


Add a dot before [jt] please.

I don't know what should be a flow now, as this PR was forked (imported) to the internal github repository... is updating this PR still something valuable ? @AlexMSmithCA

Feel free to make these changes in this PR. We can re-import any additional commits once this has been fully reviewed.

ajbogh · 2020-01-18T06:48:00Z

fusion-cli/docs/fusionrc.md

+
+ ```js
+module.exports = {
+  resolveExtensions: ['.wasm', '.mjs', '.js', '.json', '.ts', '.tsx'],


Add the following to enable Typescript-compatible tests.

jest: { globFileExt: '!(.d).(ts|tsx)' }

I don't know what should be a flow now, as this PR was forked (imported) to the internal github repository... is updating this PR still something valuable ? @AlexMSmithCA

(See above)

pheew · 2020-04-22T15:29:50Z

I just now found this PR and realized there's some overlap with the PR I'm working on #736. As this PR is much nicer in terms of changing the file extensions I'd like to build upon this and then add the ability to override the entry point on top.

What's the procedure here? It's kind of hard to know what to expect if part of the work is being done behind closed doors. What needs to happen for this to land on the master branch on this public repo?

fusionjs-bot bot added the docs label May 22, 2019

Monar force-pushed the enable-modification-of-webpack-test-pattern branch 2 times, most recently from bc8c284 to 1af5ddb Compare May 23, 2019 07:57

Monar force-pushed the enable-modification-of-webpack-test-pattern branch from 71fdfb1 to 0ae280d Compare May 30, 2019 14:00

Monar force-pushed the enable-modification-of-webpack-test-pattern branch 2 times, most recently from 4ce9f0f to ee0b7e9 Compare June 20, 2019 21:27

lhorie reviewed Jul 9, 2019

View reviewed changes

lhorie previously approved these changes Jul 9, 2019

View reviewed changes

KevinGrandon added the ci label Jul 9, 2019

UberOpenSourceBot removed the ci label Jul 9, 2019

ajbogh reviewed Jul 9, 2019

View reviewed changes

derekju reviewed Jul 9, 2019

View reviewed changes

AlexMSmithCA requested changes Nov 5, 2019

View reviewed changes

Monar dismissed lhorie’s stale review via be48fc1 November 13, 2019 13:34

Monar force-pushed the enable-modification-of-webpack-test-pattern branch from ee0b7e9 to be48fc1 Compare November 13, 2019 13:34

chrisdothtml added the ci label Nov 13, 2019

UberOpenSourceBot removed the ci label Nov 13, 2019

lee-alexander reviewed Nov 18, 2019

View reviewed changes

Monar force-pushed the enable-modification-of-webpack-test-pattern branch 2 times, most recently from dd89df7 to 5e57cef Compare November 19, 2019 15:30

Monar added 2 commits November 20, 2019 00:18

Add basic configuration to enable typescript support

3011e8c

Add jest configuration option

b404074

This change is enabling test configuration for typescript projects.

Monar force-pushed the enable-modification-of-webpack-test-pattern branch from 5e57cef to b404074 Compare November 19, 2019 23:18

Monar added 2 commits November 28, 2019 10:42

Merge branch 'master' into enable-modification-of-webpack-test-pattern

027c374

Merge branch 'master' into enable-modification-of-webpack-test-pattern

a111b70

Monar requested a review from AlexMSmithCA December 18, 2019 17:11

Monar and others added 2 commits December 18, 2019 18:11

Merge branch 'master' into enable-modification-of-webpack-test-pattern

854fb7a

Merge branch 'master' into enable-modification-of-webpack-test-pattern

b006ff2

fusionjs-sync-bot bot closed this Dec 26, 2019

AlexMSmithCA reopened this Dec 26, 2019

ajbogh previously approved these changes Jan 28, 2020

View reviewed changes

Merge branch 'master' into enable-modification-of-webpack-test-pattern

2829f39

AlexMSmithCA dismissed ajbogh’s stale review via 2829f39 June 7, 2020 01:47

pheew mentioned this pull request Oct 22, 2020

feat: allow .ts extension and support main.ts #759

Open

gutenye mentioned this pull request Nov 22, 2020

TypeScript Support for FusionJS gutenye/fusionjs#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add in fusionConfig: jsExtPattern, resolveExtensions (enable typescript) #411

Add in fusionConfig: jsExtPattern, resolveExtensions (enable typescript) #411

Monar commented May 22, 2019

CLAassistant commented May 22, 2019 •

edited

lhorie Jul 9, 2019

ajbogh Jul 9, 2019

derekju Jul 9, 2019

derekju Jul 9, 2019 •

edited

futurist commented Jul 21, 2019

Monar commented Jul 22, 2019

AlexMSmithCA left a comment

Monar commented Nov 13, 2019 •

edited

lee-alexander Nov 18, 2019

Monar Nov 19, 2019 •

edited

AlexMSmithCA commented Dec 26, 2019 •

edited

fusionjs-sync-bot bot commented Dec 26, 2019

AlexMSmithCA commented Dec 26, 2019

amarinov commented Jan 10, 2020

ajbogh Jan 16, 2020

Monar Feb 4, 2020

AlexMSmithCA Feb 4, 2020

ajbogh Jan 18, 2020

Monar Feb 4, 2020

AlexMSmithCA Feb 4, 2020

pheew commented Apr 22, 2020


		## `resolveExtensions`

		By default this is webpack default witch is: `['.wasm', '.mjs', '.js', '.json']`


		By default this is `/\.jsx?$/`

		For example, this enables to handle typescript files with addition to Babel plugins/preset:

Add in fusionConfig: jsExtPattern, resolveExtensions (enable typescript) #411

Are you sure you want to change the base?

Add in fusionConfig: jsExtPattern, resolveExtensions (enable typescript) #411

Conversation

Monar commented May 22, 2019

CLAassistant commented May 22, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekju Jul 9, 2019 • edited

Choose a reason for hiding this comment

futurist commented Jul 21, 2019

Monar commented Jul 22, 2019

AlexMSmithCA left a comment

Choose a reason for hiding this comment

Monar commented Nov 13, 2019 • edited

Choose a reason for hiding this comment

Monar Nov 19, 2019 • edited

Choose a reason for hiding this comment

AlexMSmithCA commented Dec 26, 2019 • edited

fusionjs-sync-bot bot commented Dec 26, 2019

AlexMSmithCA commented Dec 26, 2019

amarinov commented Jan 10, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pheew commented Apr 22, 2020

CLAassistant commented May 22, 2019 •

edited

derekju Jul 9, 2019 •

edited

Monar commented Nov 13, 2019 •

edited

Monar Nov 19, 2019 •

edited

AlexMSmithCA commented Dec 26, 2019 •

edited