This repository has been archived by the owner on Jan 7, 2024. It is now read-only.
test: regression coverage for #111 (KeyError due to filename), also fix ci on master #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
force-pushed
the
filename-key-regres
branch
3 times, most recently
from
449950d
to
22cb3d8
Compare
redshiftzero
force-pushed
the
filename-key-regres
branch
from
16df81f
to
84d84f0
Compare
redshiftzero
force-pushed
the
filename-key-regres
branch
from
84d84f0
to
1140d40
Compare
|
Added a commit to fix CI because CI is currently failing on master. This started happening after the virtualenv 20.0 update in the past 24 hours, which will get installed by Pipenv. Since we removed Pipenv from almost everywhere else (and it looks like it's falling into an unmaintained state: pypa/pipenv#4058), I've moved us back to pip-tools as in the other SecureDrop repositories in 1140d40. |
redshiftzero
moved this from In Development
to Ready for Review
in SecureDrop Team Board
redshiftzero
changed the title
kushaldas
approved these changes
Feb 12, 2020
emkll
added a commit
that referenced
this pull request
Oct 13, 2020
Pipenv was removed in favor of pip-tools in #112
sssoleileraaa
pushed a commit
that referenced
this pull request
Oct 13, 2020
Pipenv was removed in favor of pip-tools in #112
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#111 ended up being fixed by #110, here's a regression test (one can verify this claim by checking out 0.0.12, applying this commit, and you should reproduce the KeyError due to filename)