Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

proxy-only KeyError when file fails to download #111

Closed
redshiftzero opened this issue Feb 10, 2020 · 1 comment
Closed

proxy-only KeyError when file fails to download #111

redshiftzero opened this issue Feb 10, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@redshiftzero
Copy link
Contributor

If there's an error during downloading a submission, the key filename will not be present in the response body (see relevant code here): instead the "error" key will be present.

Thus if a download error occurs, we'll see a KeyError: 'filename' from the SDK due to this line:

filepath = os.path.join(
                "/home/user/QubesIncoming/", self.proxy_vm_name, data["filename"]
            )

We should fix this once the exception handling in #110 is merged (related).

@redshiftzero
Copy link
Contributor Author

Just checked, this was fixed by #110, added a regression test in #112

SecureDrop Team Board automation moved this from Near Term - SD Workstation to Done Feb 11, 2020
kushaldas added a commit that referenced this issue Feb 12, 2020
test: regression coverage for #111 (KeyError due to filename), also fix ci on master
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

1 participant