Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test client downloads with large file sizes #767

Closed
eloquence opened this issue Feb 4, 2020 · 3 comments
Closed

Test client downloads with large file sizes #767

eloquence opened this issue Feb 4, 2020 · 3 comments

Comments

@eloquence
Copy link
Member

We want to ensure that the client works no less reliably than downloading via Tor Browser when downloading large files (up to the 500 MB limit). This can be broken down into:

  • reliability of the API's /download endpoints over Tor
  • reliability of the download via securedrop-proxy
  • reliability of the client's own download/retry behavior

Testing within the client is an easy way to get a sense of the overall scope of any current reliability issues. Testing of the API endpoints will help us narrow down if server-side changes are required for 1.2.1 (e.g., support for range requests, tracked in freedomofpress/securedrop#3907).

@eloquence eloquence added this to Nominated for next sprint in SecureDrop Team Board Feb 4, 2020
@eloquence eloquence moved this from Nominated for next sprint to Current Sprint (2/5-2/19) in SecureDrop Team Board Feb 5, 2020
@eloquence
Copy link
Member Author

eloquence commented Feb 5, 2020

For the 2/5-2/20 sprint @kushaldas has offered to do some manual testing & profiling in the client to get us some initial data on reliability. If we discover major issues there, we can do further testing.

@eloquence
Copy link
Member Author

Kushal reported some results here.

@redshiftzero redshiftzero moved this from Current Sprint (2/5-2/20) to In Development in SecureDrop Team Board Feb 10, 2020
@redshiftzero redshiftzero self-assigned this Feb 10, 2020
@redshiftzero
Copy link
Contributor

To figure out if we need to push the server release I did some testing of this today. I tried downloading files for files in the 130 MB, 290 MB, and 450 MB size ranges (1 per file size). It worked well for me (each worked on the first try). This was done on latest versions of all packages as of the date of this comment in a Qubes test environment running on the workstation staging scenario against a staging app server. I investigated the KeyError @kushaldas reported and have an explanation here and it should be resolved if we fix freedomofpress/securedrop-sdk#111. I'm going to close this and we can do more testing of file downloads during the workstation QA period as part of the regular test plan.

SecureDrop Team Board automation moved this from In Development to Done Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants