Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/r17 exmaple #37

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Feat/r17 exmaple #37

wants to merge 14 commits into from

Conversation

ianchen0119
Copy link
Contributor

No description provided.

Comment on lines +24 to +27
// Index is the index handler.
func Index(c *gin.Context) {
c.String(http.StatusOK, "Hello World!")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@@ -93,7 +108,7 @@ func HTTPAccessTokenRequest(c *gin.Context) {
req := httpwrapper.NewRequest(c.Request, accessTokenReq)
req.Params["paramName"] = c.Params.ByName("paramName")

httpResponse := producer.HandleAccessTokenRequest(req)
httpResponse := s.Processor().HandleAccessTokenRequest(req)
Copy link
Contributor

@andy89923 andy89923 Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response to be check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been done in step 11.

@ianchen0119
Copy link
Contributor Author

Note:
It seems like go 1.18 can not support to build the NF with R17 openapi.
We should change the go version in ci from 1.18 to 1.19.

Besides,
We should update the existed Unit Test to fit the latest implemented function(s).

@@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go: [ '1.18' ]
go: [ '1.19' ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 1.21

@@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go: [ '1.18', '1.21' ]
go: [ '1.19', '1.21' ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 1.21 only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants