fix: fix linter

.github/workflows/golangci-lint.yml

@@ -25,7 +25,7 @@ jobs:
         uses: golangci/golangci-lint-action@v3
         with:
           # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
-          version: v1.45.2
+          version: v1.57.2
 
           # Optional: working directory, useful for monorepos
           # working-directory: somedir

.golangci.yml

@@ -44,7 +44,7 @@ run:
 # output configuration options
 output:
   # colored-line-number|line-number|json|tab|checkstyle|code-climate, default is "colored-line-number"
-  format: colored-line-number
+  formats: colored-line-number
   # print lines of code with issue, default is true
   print-issued-lines: true
   # print linter name in the end of issue text, default is true
@@ -149,7 +149,7 @@ linters-settings:
         #     reason: "testing if blocked version constraint works."  # Reason why the version constraint exists. (Optional)
   govet:
     # report about shadowed variables
-    check-shadowing: true
+    # check-shadowing: true
     # settings per analyzer
     settings:
       printf: # analyzer name, run `go tool vet help` to see all analyzers
@@ -161,9 +161,8 @@ linters-settings:
     # enable or disable analyzers by name
     enable:
       - atomicalign
-    enable-all: false
-    disable:
       - shadow
+    enable-all: false
     disable-all: false
   depguard:
     list-type: blacklist

internal/sbi/api_accesstoken.go

@@ -1,7 +1,8 @@
 /*
  * NRF OAuth2
  *
- * NRF OAuth2 Authorization.   © 2022, 3GPP Organizational Partners (ARIB, ATIS, CCSA, ETSI, TSDSI, TTA, TTC).   All rights reserved.
+ * NRF OAuth2 Authorization.
+ * © 2022, 3GPP Organizational Partners (ARIB, ATIS, CCSA, ETSI, TSDSI, TTA, TTC).   All rights reserved.
  *
  * API version: 1.2.1
  * Generated by: OpenAPI Generator (https://openapi-generator.tech)
@@ -14,10 +15,11 @@ import (
 	"net/http"
 	"reflect"
 
+	"github.com/gin-gonic/gin"
+
 	"github.com/free5gc/nrf/internal/logger"
 	"github.com/free5gc/nrf/pkg/factory"
 	"github.com/free5gc/openapi/models"
-	"github.com/gin-gonic/gin"
 )
 
 // Index is the index handler.
@@ -89,7 +91,7 @@ func (s *Server) apiAccessTokenRequest(c *gin.Context) {
 		}
 	}
 
-	if err := s.bindData(c, &accessTokenReq); err != nil {
+	if err1 := s.bindData(c, &accessTokenReq); err1 != nil {
 		return
 	}
 	if err != nil {

internal/sbi/processor/accesstoken.go

@@ -6,6 +6,9 @@ import (
 	"strings"
 	"time"
 
+	"github.com/golang-jwt/jwt"
+	"go.mongodb.org/mongo-driver/bson"
+
 	nrf_context "github.com/free5gc/nrf/internal/context"
 	"github.com/free5gc/nrf/internal/logger"
 	"github.com/free5gc/nrf/pkg/factory"
@@ -14,8 +17,6 @@ import (
 	"github.com/free5gc/openapi/oauth"
 	"github.com/free5gc/util/mapstruct"
 	"github.com/free5gc/util/mongoapi"
-	"github.com/golang-jwt/jwt"
-	"go.mongodb.org/mongo-driver/bson"
 )
 
 func (p *Processor) AccessTokenProcedure(request models.AccessTokenReq) *HandlerResponse {

internal/sbi/server.go

@@ -152,6 +152,7 @@ func (s *Server) startServer(wg *sync.WaitGroup) {
 	logger.SBILog.Warnf("SBI server (listen on %s) stopped", s.httpServer.Addr)
 }
 
+// nolint
 func checkContentTypeIsJSON(gc *gin.Context) (string, error) {
 	var err error
 	contentType := gc.GetHeader("Content-Type")
@@ -169,6 +170,7 @@ func checkContentTypeIsJSON(gc *gin.Context) (string, error) {
 	return contentType, nil
 }
 
+// nolint
 func (s *Server) deserializeData(gc *gin.Context, data interface{}, contentType string) error {
 	reqBody, err := gc.GetRawData()
 	if err != nil {

pkg/factory/factory.go

@@ -6,7 +6,7 @@ package factory
 
 import (
 	"fmt"
-	"io/ioutil"
+	"os"
 
 	"github.com/asaskevich/govalidator"
 	"gopkg.in/yaml.v2"
@@ -23,7 +23,7 @@ func InitConfigFactory(f string, cfg *Config) error {
 		f = NrfDefaultConfigPath
 	}
 
-	if content, err := ioutil.ReadFile(f); err != nil {
+	if content, err := os.ReadFile(f); err != nil {
 		return fmt.Errorf("[Factory] %+v", err)
 	} else {
 		logger.CfgLog.Infof("Read config from [%s]", f)

pkg/service/init.go

@@ -2,7 +2,7 @@ package service
 
 import (
 	"context"
-	"io/ioutil"
+	"io"
 	"os"
 	"runtime/debug"
 	"sync"
@@ -90,15 +90,15 @@ func (a *NrfApp) SetLogEnable(enable bool) {
 	logger.MainLog.Infof("Log enable is set to [%v]", enable)
 	if enable && logger.Log.Out == os.Stderr {
 		return
-	} else if !enable && logger.Log.Out == ioutil.Discard {
+	} else if !enable && logger.Log.Out == io.Discard {
 		return
 	}
 
 	a.cfg.SetLogEnable(enable)
 	if enable {
 		logger.Log.SetOutput(os.Stderr)
 	} else {
-		logger.Log.SetOutput(ioutil.Discard)
+		logger.Log.SetOutput(io.Discard)
 	}
 }