Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: warn if wkhtmltopdf is invalid #26174

Merged
merged 5 commits into from Apr 30, 2024
Merged

chore: warn if wkhtmltopdf is invalid #26174

merged 5 commits into from Apr 30, 2024

Commits on Apr 26, 2024

  1. chore: warn if wkhtmltopdf is invalid 

    wkhtmltopdf ( with patched qt ) is required to generate pdfs.
when user clicks on PDF, pdf will be generated and downloaded.
however, on print preview page warning will be shown.
    @maharshivpatel
    maharshivpatel committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    90f80b0 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. chore: refactor based on review comments

    @maharshivpatel
    maharshivpatel committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7ea4413 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into chore-warn-invalid-wkhtmltopdf

    @maharshivpatel
    maharshivpatel committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1401695 View commit details
    Browse the repository at this point in the history

  3. chore: return False incase of exception

    @maharshivpatel
    maharshivpatel committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6d359a9 View commit details
    Browse the repository at this point in the history

  4. chore: refactor and better naming 

    Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
    @maharshivpatel @ankush
    maharshivpatel and ankush committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    970e63e View commit details
    Browse the repository at this point in the history