chore: warn if wkhtmltopdf is invalid #26174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkhtmltopdf ( with patched qt ) is required to generate pdfs. when user clicks on PDF, pdf will be generated and downloaded. however, on print preview page warning will be shown.
github-actions
bot
added
the
add-test-cases
akhilnarang
previously requested changes
Apr 29, 2024
ankush
reviewed
Apr 29, 2024
akhilnarang
reviewed
Apr 30, 2024
ankush
reviewed
Apr 30, 2024
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* chore: warn if wkhtmltopdf is invalid wkhtmltopdf ( with patched qt ) is required to generate pdfs properly. when user clicks on PDF, pdf will be generated and downloaded. however, on print preview page warning will be shown. * chore: refactor based on review comments * chore: return False incase of exception * chore: refactor and better naming Co-authored-by: Ankush Menat <ankushmenat@gmail.com> (cherry picked from commit 6a6ded1)
maharshivpatel
added a commit
that referenced
this pull request
Apr 30, 2024
…-26174 chore: warn if wkhtmltopdf is invalid (backport #26174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wkhtmltopdf ( with patched qt ) is required to generate pdfs. when user clicks on PDF, it will be generated and downloaded. however, on print preview page warning will be shown.