Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Bump react-mosaic-component from 5.3.0 to 6.0.1 #5851

Merged
merged 9 commits into from
May 24, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 27, 2023

Bumps react-mosaic-component from 5.3.0 to 6.0.1.

Release notes

Sourced from react-mosaic-component's releases.

v6.0.1

Bugfixes

  • Stop pulling all of lodash into the bundle #206 (🎩 @​fvsch)

v6.0.0

Possibly breaking change

  • Upgrades react-dnd to ^16 as well as change some internally exported classes to make that possible #195 (🎩 @​jtbandes)

Bugfixes

  • Removes an event.stopPropagation() call in Split.tsx #202
Commits
  • 74f69ed v6.0.1
  • 163181d Merge pull request #207 from fvsch/fvsch/import-lodash-functions-explicitly
  • 1da3e7c Fix lodash bare import in OptionalBlueprint.tsx
  • fdfbc10 Add tslint rule forbidding lodash bare import
  • c074f90 v6.0.0
  • cf4f005 Merge pull request #204 from nomcopter/continue-dependency-update
  • 2d2d62a Merge branch 'master' into continue-dependency-update
  • ca33316 Remove event.stopPropagation()
  • 8bbc470 Upgrade prettier
  • a4dd544 Downgrade mocha to a version before it knew about ESM...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot bot and others added 3 commits April 27, 2023 00:15
Bumps [react-mosaic-component](https://github.com/nomcopter/react-mosaic) from 5.3.0 to 6.0.1.
- [Release notes](https://github.com/nomcopter/react-mosaic/releases)
- [Commits](nomcopter/react-mosaic@v5.3.0...v6.0.1)

---
updated-dependencies:
- dependency-name: react-mosaic-component
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@jtbandes jtbandes force-pushed the dependabot/npm_and_yarn/react-mosaic-component-6.0.1 branch from 851352f to 265739c Compare April 27, 2023 00:59
jtbandes
jtbandes previously approved these changes Apr 27, 2023
@jtbandes
Copy link
Member

Something bad happens when upgrading react-dnd. The drag source is getting prematurely disconnected:

image

This same issue originally happened to me while working on #1849. Because it happened then, I thought it was related to react-dnd/react-dnd#3290, which seemed like the only relevant change in that release. I was hoping that a future release (2 major versions later) would resolve the issue, but it's still happening ☹️

@jtbandes jtbandes dismissed their stale review April 27, 2023 01:49

needs debugging

@jtbandes
Copy link
Member

jtbandes commented May 5, 2023

This is blocked on react-dnd/react-dnd#3565. Since there's been no response on that PR we may need to apply the patch ourselves.

Copy link
Member

@jtbandes jtbandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @defunctzombie to review patch for react-dnd/react-dnd#3565

Copy link
Contributor

@defunctzombie defunctzombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If we find ourselves wanting to update this patch I think we should fork react-dnd and use our version. Upstream has no updates and if it ever comes alive we can use upstream again. But we can use the patch until we need to iterate more.

@jtbandes jtbandes merged commit 0a255b6 into main May 24, 2023
13 of 14 checks passed
@jtbandes jtbandes deleted the dependabot/npm_and_yarn/react-mosaic-component-6.0.1 branch May 24, 2023 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants