update to sassc-rails #287
Conversation
Keep getting the sass eol error when running bundle install. The sass gem reached end of life March 26, 2019. This change is switching to use sassc-rails, which uses the new C implementation of Sass as requested in issue foundation#278. I also added rails 6.0 to the appraisal test.
Getting this error in Travis CI: Name: bundler Version: 2.1.0 File: bundler-2.1.0.gem bundler's executable "bundle" conflicts with /home/travis/.rvm/rubies/ruby-2.3.8/bin/bundle Overwrite the executable? [yN] specify the bundler version in travis.yml so it matches what's in the Gemfile.lock.
| @@ -203,8 +212,8 @@ DEPENDENCIES | |||
| railties | |||
| rake | |||
| rspec (~> 3.2) | |||
| sass | |||
There was a problem hiding this comment.
With sass being removed here, I still see sass listed further up in the gem specs section of the lock file. I would think it would be removed from there too. Was there no other changes with this lock file? The gemspec file was updated but not sure why each of the rails lock files have sass specified still.
.travis.yml
Outdated
|
|
||
| before_install: | ||
| - gem update --system --no-doc | ||
| - gem install bundler | ||
| - gem install -v 1.17.3 bundler --no-rdoc --no-ri | ||
| - bundle _1.17.3_ install |
There was a problem hiding this comment.
We should remove this as Travis will run this command automatically with the specific version of bundler we have installed.
| - bundle _1.17.3_ install |
.travis.yml
Outdated
|
|
||
| before_install: | ||
| - gem update --system --no-doc | ||
| - gem install bundler | ||
| - gem install -v 1.17.3 bundler --no-rdoc --no-ri |
There was a problem hiding this comment.
The build is failing but I'm not sure if its getting to this point. Could you please update the before_install to the following and push to see if it helps at all?
before_install:
- gem update --system
- gem install bundler:1.17.3There was a problem hiding this comment.
Yikes, sorry about that @cparker-ajla. Could you try this instead:
- gem install bundler -v "1.17.3"There was a problem hiding this comment.
Thank you for all your help getting past this error @javierjulio!
|
@cparker-ajla thanks! Now we are getting a different error. I think the problem may be related to the gemspec path and gemfiles based on what I look up for that error message. Here is a sample error from one of the builds: |
|
No problem! Thanks for tackling this. Let me know if you have an update and/or need help. I'm not familiar with appraisals so I'm not sure why the builds are failing. The the lock files in |
Keep getting the sass eol error when running bundle install. The sass gem reached end of life March 26, 2019. This change is switching to use sassc-rails, which uses the new C implementation of Sass as requested in issue #278. I also added rails 6.0 to the appraisal test.