Update to sassc rails #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 19, 2019 13:16
Keep getting the sass eol error when running bundle install. The sass gem reached end of life March 26, 2019. This change is switching to use sassc-rails, which uses the new C implementation of Sass as requested in issue foundation#278. I also added rails 6.0 to the appraisal test.
Getting this error in Travis CI: Name: bundler Version: 2.1.0 File: bundler-2.1.0.gem bundler's executable "bundle" conflicts with /home/travis/.rvm/rubies/ruby-2.3.8/bin/bundle Overwrite the executable? [yN] specify the bundler version in travis.yml so it matches what's in the Gemfile.lock.
try to fix failing build as suggested by @javierjulio
remove extra space
fix to bundler version
p8
force-pushed
the
update-to-sassc-rails
branch
from
79b93e2
to
2b550e9
Compare
p8
force-pushed
the
update-to-sassc-rails
branch
from
2b550e9
to
7f92315
Compare
Also update other rubies to latest patch version
p8
force-pushed
the
update-to-sassc-rails
branch
from
f58cb06
to
be6eac3
Compare
chnikki
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #287 by @cparker-ajla
I've replaced 'sass' with 'sassc' in the gemspec.
The "You are trying to install in deployment mode after changing your Gemfile" errors have been fixed by running:
bundle exec appraisal install.The error occured because when Travis tries to run
bundler installon the appraisals Gemfiles it would change the appraisals Gemfile.lock. Running:bundle exec appraisal installand commiting the lock files prevents this error.Ruby 2.3.8 has been removed from the build matrix because it is end-of-life and fails with Rails 6.
Rails 6 requires some more work. See #282