Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update an IconButton sample, add RaisedButton sample #27169

Merged
merged 5 commits into from Feb 8, 2019
Merged

Update an IconButton sample, add RaisedButton sample #27169

merged 5 commits into from Feb 8, 2019

Conversation

Kartik1607
Copy link
Contributor

@Kartik1607 Kartik1607 commented Jan 28, 2019 •
edited by HansMuller

Corrects the first IconButton sample, adds a RaisedButton sample.

Fixes #27168
Fixes #12382

@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ labels Jan 28, 2019
HansMuller
HansMuller requested changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. If you'll update the 2nd example with the suggested changes, I'll be happy to land the result!

packages/flutter/lib/src/material/raised_button.dart Outdated Show resolved Hide resolved
@HansMuller HansMuller mentioned this pull request Jan 29, 2019
Closed
@HansMuller HansMuller changed the title Icon button sample update Update an IconButton sample, add RaisedButton sample Feb 1, 2019
@HansMuller HansMuller mentioned this pull request Feb 1, 2019
Closed
@Kartik1607
Copy link
Contributor Author

@HansMuller updated the code :)

@HansMuller
Copy link
Contributor

It turns out that the snippet does in fact need a build method. I'll fix that up and land this when the build has stabilized.

Once this PR has been landed in the repo it will start running the final testing gauntlet. You can watch its status here: https://flutter-dashboard.appspot.com/build.html

@HansMuller
Copy link
Contributor

I was wrong, a build method isn't needed. Yes this is confusing (to me).

@HansMuller HansMuller merged commit b7807ce into flutter:master Feb 8, 2019
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
@Kartik1607 @kangwang1988
Update an IconButton sample, add RaisedButton sample (flutter#27169)
e516890
@Kartik1607 Kartik1607 deleted the IconButtonSample branch February 13, 2019 05:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
4 participants
@Kartik1607 @HansMuller @zoechi @googlebot