Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sample code for RaisedButton widget #22493

Conversation

laertispappas
Copy link

Addresses #12382 and #21136

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@laertispappas
Copy link
Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

/// );
/// }
/// }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extraneous blank line

/// }
/// }

///
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: also here

@Hixie
Copy link
Contributor

Hixie commented Oct 17, 2018

This looks great, just some minor nits!

When you update this you'll probably find it complains about MyHomePage being already used. You'll need to change the class name to be different than in any other example, e.g. CounterPage or something.

@laertispappas
Copy link
Author

@Hixie thanks for the feedback. I will follow up.

@laertispappas
Copy link
Author

@Hixie I have updated the code. Wanna have alook? Thank you in advance.

@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ labels Nov 28, 2018
@HansMuller
Copy link
Contributor

Please accept my apologies for not getting your contribution landed. I'm afraid it got lost in the final push for Flutter 1.0. That's no excuse really, sorry about dropping it.

Since then another developer has contributed a RaisedButton sample, #27169, which will serve as well.

I'm going to close this PR. I hope this will not discourage you from future contributions!

@HansMuller HansMuller closed this Feb 1, 2019
@laertispappas laertispappas deleted the adds_example_for_raised_buttons branch February 1, 2019 21:30
@laertispappas
Copy link
Author

@HansMuller thanks for the update and your message. It's okay I understand. I hope I get more involved in the near future.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants