New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds sample code for RaisedButton widget #22493
Adds sample code for RaisedButton widget #22493
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
9e8e6ef
to
e83d86f
Compare
CLAs look good, thanks! |
/// ); | ||
/// } | ||
/// } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extraneous blank line
/// } | ||
/// } | ||
|
||
/// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: also here
This looks great, just some minor nits! When you update this you'll probably find it complains about MyHomePage being already used. You'll need to change the class name to be different than in any other example, e.g. CounterPage or something. |
@Hixie thanks for the feedback. I will follow up. |
e83d86f
to
ca90bf0
Compare
@Hixie I have updated the code. Wanna have alook? Thank you in advance. |
Please accept my apologies for not getting your contribution landed. I'm afraid it got lost in the final push for Flutter 1.0. That's no excuse really, sorry about dropping it. Since then another developer has contributed a RaisedButton sample, #27169, which will serve as well. I'm going to close this PR. I hope this will not discourage you from future contributions! |
@HansMuller thanks for the update and your message. It's okay I understand. I hope I get more involved in the near future. |
Addresses #12382 and #21136