Gamescope / MangoApp: Refactored FSR hud element to be technology independent / added scaler #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed parameter "fsr", added "filter".
- Refactored fsrSharpness to scaler sharpness, as the data already reflect it - Refactored parameter hide_fsr_sharpness to hide_scaler_additional, to be technology agnostic
Root-Core
changed the title
| else | ||
| HUDElements.g_fsrSharpness = params.fsr_steam_sharpness - mangoapp_v1->fsrSharpness; | ||
| HUDElements.g_scaler_sharpness = params.fsr_steam_sharpness - mangoapp_v1->scaler_sharpness; |
There was a problem hiding this comment.
fsr_steam_sharpness is the maximum sharpness. To get the same value that the steam UI uses we do fsr_steam_sharpness - gamescope reported.
Steam also adds nis_steam_sharpness which we don't have a param for yet and should be calculated the same way as fsr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Gamescope has also implemented NIS, a single FSR output is really limited. They might add even more filters in the future, so it would be nice to have a singular output for all filters.
Also there is currently no output for the used scaler, which will be a easier to set option if ValveSoftware/gamescope#893 or cycling the settings get merged.
I have repurposed the FSR field, please forgive me. I think a double inclusion of FSR would be wasteful.Thank you!Feedback regarding this situation is appreciated and necessary.
PR for Gamescope: ValveSoftware/gamescope#895
EDIT:
To be technology agnostic, I have renamed the parameter
hide_fsr_sharpnesstohide_scaler_additional.This might be a "breaking change" to somebody, but it's undocumented so it shouldn't affect many people.
EDIT 2:
The parameter
fsr_steam_sharpnessis the last one referencing FSR explicitly, but I do not understand what it's used for and by whom. Should it stay untouched?