Shortcut for cycling scalers and filters / Output in MangoApp #895
Conversation
Changed types of used enums and fsr sharpness to uint8_t, to prevent future mistakes
| @@ -19,12 +19,15 @@ struct mangoapp_msg_v1 { | |||
|
|
|||
| uint32_t pid; | |||
| uint64_t visible_frametime_ns; | |||
| uint8_t fsrUpscale; | |||
| uint8_t fsrSharpness; | |||
| uint8_t fsrUpscale; // deprecated | |||
There was a problem hiding this comment.
This actually showed whether FSR was doing anything not whether it was selected.
it 1280x800 game on 1280x800 output would show disabled here even if FSR was disabled.
There was a problem hiding this comment.
Okay, I understand. With a quick look at the sources it seems to be only activated if upscaling is necessary.
gamescope/src/steamcompmgr.cpp
Lines 2263 to 2265 in 7a1fe2d
Off-topic: While I'm not knowledgeable in this matter, it might also be beneficial to filter / sharpen images that aren't (up-)scaled. #702
To be technology agnostic: The same behavior applies to NIS.
There isn't any feedback currently, as the g_bFSRActive flag and GAMESCOPE_FSR_FEEDBACK atom explicitly reference FSR and only get triggered if FSR is used. I know nothing about Xlib and how this atom is used, but we should consider refactoring these technology specific bits. I can't find any other tool / program online, that references this specific atom though.
Nevertheless, if there is a reason to only use the filters on upscaled frames and keep the flag, it might be better to add a scaler_filter_active and keep fsrUpscale deprecated.
BTW: fsrUpscale still gets populated at the moment, so we are able to check / show this in MangoApp.
There was a problem hiding this comment.
It would be okay to repurprose this and the atom for a generic 'upscaling active'
There was a problem hiding this comment.
Regarding MangoApp, repurposing / renaming is denied (flightlessmango/MangoHud#1042 (comment)), adding fields would be the way to go for the IPC.
I can refactor the internal variables / logic though, so that it is generic.
You should decide if it is okay to rename the atom.
As discussed in #893, I have implemented key bindings to cycle through the upscalers and filters.
I have not removed the existing shortcuts yet, as you can not determine which scaler is active for now.
I added the current scaler settings to the mango message protocol, as it supports FSR only atm.
The PR to show it in MangoHud: flightlessmango/MangoHud#1042
The new shortcuts are
Super + X(scalers) andSuper + Z(filters).This keys are one of the last ones that do not trigger something in my DE (KDE Plasma) and they are neighbors.
They are placeholders though. If there is a better idea, we should change them before they are merged.