Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kaios simulator on linux #1450

Merged
merged 2 commits into from Mar 12, 2024
Merged

Fix kaios simulator on linux #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
526b1af
small fix
Marius456 Mar 12, 2024
f02b9bd
fix kaios sim run command
Marius456 Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/schema/configFiles/workspace.ts
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ const SDKsSchema = z
// ANDROID_NDK: '~/Library/Android/sdk/ndk-bundle',
// TIZEN_SDK: '~/tizen-studio',
// WEBOS_SDK: '/opt/webOS_TV_SDK',
// KAIOS_SDK: '~/Library/KaiosSimulators',
// KAIOS_SDK: '~/Applications/KaiosSimulators',

//LEVEl 0 (ROOT)

Expand Down
2 changes: 1 addition & 1 deletion packages/rnv/coreTemplateFiles/global-config-template.json
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@
"ANDROID_NDK": "/Users/<USER>/Library/Android/sdk/ndk-bundle",
"TIZEN_SDK": "/Users/<USER>/tizen-studio",
"WEBOS_SDK": "/Users/<USER>/Library/webOS_TV_SDK",
"KAIOS_SDK": "/Users/<USER>/Library/KaiosSimulators"
"KAIOS_SDK": "/Applications/KaiosSimulators"
},
"defaultTargets": {
"android": "Nexus_5X_API_26",
Expand Down
15 changes: 4 additions & 11 deletions packages/sdk-kaios/src/deviceManager.ts
View file
Open in desktop
Expand Up @@ -40,15 +40,8 @@ export const launchKaiOSSimulator = async (target: string | boolean) => {
return Promise.reject(`Can't find simulator at path: ${simulatorPath}`);
}

await executeAsync(`${simulatorPath}`, ExecOptionsPresets.NO_SPINNER_FULL_ERROR_SUMMARY);

// new Promise<void>((resolve, reject) => {
// childProcess.exec(`(cd ${kaiosSdkPath}/${target}/kaiosrt && ${simulatorPath} )`, (err: RnvError) => {
// if (err) {
// reject(err);
// return;
// }
// resolve();
// });
// });
await executeAsync(simulatorPath, {
cwd: `${kaiosSdkPath}/${target}/kaiosrt`,
...ExecOptionsPresets.NO_SPINNER_FULL_ERROR_SUMMARY,
});
};