Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kaios simulator on linux #1450

Merged
merged 2 commits into from Mar 12, 2024
Merged

Conversation

Marius456
Copy link
Contributor

@Marius456 Marius456 commented Mar 7, 2024

Description

  • Fix kaios simulator wrong extension

Related issues

Npm releases

n/a

NOTE:
test this PR following following:

@Marius456 Marius456 added this to the 1.1 milestone Mar 7, 2024
@Marius456 Marius456 self-assigned this Mar 7, 2024
@Marius456 Marius456 changed the base branch from release/1.0 to main March 7, 2024 16:41
@Marius456 Marius456 changed the base branch from main to release/1.0 March 7, 2024 16:41
@Marius456 Marius456 marked this pull request as draft March 7, 2024 16:44
@Marius456 Marius456 added the e2e label Mar 8, 2024
@pavjacko pavjacko modified the milestones: 1.1, 1.0 Mar 8, 2024
@Marius456 Marius456 added e2e and removed e2e labels Mar 9, 2024
@Marius456 Marius456 marked this pull request as ready for review March 10, 2024 08:40
Copy link
Member

@pavjacko pavjacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marius456
make sure your husky commit hooks running correctly or you do not commit final changes with --no-verify which disables local checks.

renative/packages/sdk-kaios/src/deviceManager.ts
   1:37   error  'chalk' is defined but never used                                      @typescript-eslint/no-unused-vars
   1:78   error  'logError' is defined but never used                                   @typescript-eslint/no-unused-vars
   1:88   error  'executeAsync' is defined but never used                               @typescript-eslint/no-unused-vars
   1:102  error  'logSuccess' is defined but never used                                 @typescript-eslint/no-unused-vars
  16:13   error  'availableSimulatorVersions' is never reassigned. Use 'const' instead  prefer-const

you can check this manually as well by running yarn sanity

packages/sdk-kaios/src/deviceManager.ts Outdated Show resolved Hide resolved
@pavjacko pavjacko mentioned this pull request Mar 11, 2024
packages/core/src/schema/configFiles/workspace.ts Outdated Show resolved Hide resolved
packages/rnv/coreTemplateFiles/global-config-template.json Outdated Show resolved Hide resolved
packages/sdk-kaios/src/deviceManager.ts Outdated Show resolved Hide resolved
packages/sdk-kaios/src/deviceManager.ts Outdated Show resolved Hide resolved
packages/sdk-kaios/src/deviceManager.ts Outdated Show resolved Hide resolved
@Marius456 Marius456 marked this pull request as draft March 12, 2024 06:43
@Marius456 Marius456 changed the base branch from release/1.0 to chore/release_sync_2 March 12, 2024 07:48
@Marius456 Marius456 added e2e and removed e2e labels Mar 12, 2024
@Marius456 Marius456 marked this pull request as ready for review March 12, 2024 07:56
@Marius456 Marius456 added e2e and removed e2e labels Mar 12, 2024
@pavjacko pavjacko merged commit aa748c9 into chore/release_sync_2 Mar 12, 2024
3 checks passed
@Marius456 Marius456 deleted the fix/run_kaios_sim branch March 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants