Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webos] simulator fails to be launched on linux system #1446

Merged
merged 4 commits into from Mar 8, 2024
Merged

[webos] simulator fails to be launched on linux system #1446

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7389d5
change linux webos launch cli
Marius456 Mar 6, 2024
5f0cda0
migrate options to preset
Marius456 Mar 8, 2024
f4b9c4c
Merge branch 'release/1.0' into fix/linux_launch_webos_sim
Marius456 Mar 8, 2024
030a1c7
small merge fix
Marius456 Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/sdk-webos/src/deviceManager.ts
View file
Open in desktop
Expand Up @@ -73,11 +73,10 @@ export const launchWebOSimulator = async (c: RnvContext, target: string) => {
if (!fsExistsSync(ePath)) {
return Promise.reject(`Can't find simulator at path: ${ePath}`);
}
if (isSystemWin) {
return executeAsync(c, ePath, { detached: true, stdio: 'ignore' });
if (isSystemWin || isSystemLinux) {
return executeAsync(c, ePath, ExecOptionsPresets.SPINNER_FULL_ERROR_SUMMARY);
}

await executeAsync(c, `${openCommand} ${ePath}`, { detached: true });
await executeAsync(c, `${openCommand} ${ePath}`, ExecOptionsPresets.FIRE_AND_FORGET);
logSuccess(`Succesfully launched ${selectedOption}`);
return true;
};
Expand Down