Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webos] simulator fails to be launched on linux system #1446

Merged
merged 4 commits into from Mar 8, 2024
Merged

[webos] simulator fails to be launched on linux system #1446

merged 4 commits into from Mar 8, 2024

Conversation

Marius456
Copy link
Contributor

Description

  • Fixed linux target launch command for webos.

Related issues

Npm releases

n/a

@Marius456 Marius456 added this to the 1.0 milestone Mar 6, 2024
@Marius456 Marius456 self-assigned this Mar 6, 2024
@Marius456 Marius456 added the e2e label Mar 6, 2024
@pauliusguzas pauliusguzas self-requested a review March 7, 2024 17:12
pauliusguzas
pauliusguzas reviewed Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@pauliusguzas pauliusguzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on macos command exits after launching simulator, while on linux it remains running, not sure if that's a bug
image

@pauliusguzas pauliusguzas self-requested a review March 8, 2024 08:31
pavjacko
pavjacko requested changes Mar 8, 2024
View reviewed changes
packages/sdk-webos/src/deviceManager.ts Outdated Show resolved Hide resolved
@Marius456 Marius456 added e2e and removed e2e labels Mar 8, 2024
@Marius456 Marius456 merged commit d5022bd into release/1.0 Mar 8, 2024
3 checks passed
@Marius456 Marius456 deleted the fix/linux_launch_webos_sim branch March 8, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavjacko pavjacko pavjacko approved these changes

@mihaiblaga89 mihaiblaga89 mihaiblaga89 approved these changes

@pauliusguzas pauliusguzas pauliusguzas approved these changes

Assignees

@Marius456 Marius456

Labels
e2e
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Marius456 @pavjacko @mihaiblaga89 @pauliusguzas